vdk-control-cli: Make schedule_cron config param optional #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows for jobs to be deployed without the schedule_cron parameter specified. In such a case, the job receives a default value '0 0 30 2 *', which would run on Feb 30, or never. Testing done: deployed job and verified the schedule is correct Signed-off-by: Gabriel Georgiev <[email protected]>
Signed-off-by: Gabriel Georgiev <[email protected]>
antoniivanov
reviewed
May 9, 2022
projects/vdk-control-cli/src/vdk/internal/control/command_groups/job/deploy_cli_impl.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Gabriel Georgiev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows for jobs to be deployed without
the schedule_cron parameter specified.
Testing done: deployed job and verified warning is printed
Signed-off-by: Gabriel Georgiev [email protected]