versatile-data-kit: allow commit with any newer version of python #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If users run pre-commit hook locally they need python. Due to pre-commit/pre-commit#1375 it seems the pre-commit hooks is failing if there's no python3.7 because we've specified in black to use it. We are loosing the version to python 3.7 so that it's eaiser to develop with any version Testing Done: ran git commit in docker container using only python 3.9 and saw (after the change) it no longer fails. Signed-off-by: Antoni Ivanov <[email protected]>x
antoniivanov
changed the title
gabrielgeorgiev1
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If users run pre-commit hook locally they need python. Due to
pre-commit/pre-commit#1375 it seems the
pre-commit hooks is failing if there's no python3.7 because we've
specified in black to use it. We are loosing the version to python 3.7
so that it's eaiser to develop with any version
Testing Done: ran git commit in docker container using only python 3.9
and saw (after the change) it no longer fails.
Signed-off-by: Antoni Ivanov [email protected]x