airflow-provider-vdk: VDKOperator execute method #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriel Georgiev <[email protected]>
Signed-off-by: Gabriel Georgiev <[email protected]>
Signed-off-by: Gabriel Georgiev <[email protected]>
mivanov1988
approved these changes
May 9, 2022
|
LGTM |
doks5
reviewed
May 9, 2022
projects/vdk-plugins/airflow-provider-vdk/tests/operators/test_vdkoperator.py
Show resolved
Hide resolved
Signed-off-by: Gabriel Georgiev <[email protected]>
Fixed it, it was caused by the VDKHook change to the start_job_execution method. |
Signed-off-by: Gabriel Georgiev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements the execute method for the VDKOperator.
This method triggers a job. execution and is ran when the operator
is used inside an Airflow DAG.
Testing done: tested locally, unit test
Signed-off-by: Gabriel Georgiev [email protected]