[vdk-plugins] vdk-control-api-auth: Add api-token flow #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doks5
force-pushed
the
person/andonova/vdk-auth
branch
from
1521089 to
cf7416b
Compare
projects/vdk-plugins/vdk-control-api-auth/src/vdk/plugin/control_api_auth/authentication.py
Show resolved
Hide resolved
antoniivanov
reviewed
May 3, 2022
doks5
force-pushed
the
person/andonova/vdk-auth
branch
3 times, most recently
from
af79e35 to
8690b44
Compare
antoniivanov
approved these changes
May 3, 2022
As part of the ongoing work to extract the authentication login of Versatile Data Kit into a stand-alone library and make it available to all components (core and plugins) to use, we need to ensure that the interface surface is as generic as possible. This change introduces an`Authentication` class, which will act as the entry point for using the library and authenticating. Additionally, the api token authentication flow from vdk-control-cli is also adapted and added to vdk-control-api-auth. Testing Done: Unit tests. Signed-off-by: Andon Andonov <[email protected]>
doks5
force-pushed
the
person/andonova/vdk-auth
branch
from
8690b44 to
feade87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the ongoing work to extract the authentication login of
Versatile Data Kit into a stand-alone library and make it available
to all components (core and plugins) to use, we need to ensure that
the interface surface is as generic as possible.
This change introduces an
Authenticationclass, which will act asthe entry point for using the library and authenticating.
Additionally, the api token authentication flow from vdk-control-cli
is also adapted and added to vdk-control-api-auth.
Testing Done: Unit tests.
Signed-off-by: Andon Andonov [email protected]