airflow-provider-vdk: VDKSensor poke method #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change implements the poke method of the VDKSensor, which checks the status of a particular job execution, returns True if the execution is successful, false if it is not yet complete, and raises an exception if the job execution has been cancelled, skipped or has failed. Testing done: TBD Signed-off-by: Gabriel Georgiev <[email protected]>
Signed-off-by: Gabriel Georgiev <[email protected]>
Signed-off-by: Gabriel Georgiev <[email protected]>
Signed-off-by: Gabriel Georgiev <[email protected]>
mivanov1988
reviewed
Apr 27, 2022
projects/vdk-plugins/airflow-provider-vdk/vdk_provider/sensors/vdk.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Gabriel Georgiev <[email protected]>
mivanov1988
reviewed
Apr 28, 2022
projects/vdk-plugins/airflow-provider-vdk/vdk_provider/sensors/vdk.py
Outdated
Show resolved
Hide resolved
mivanov1988
reviewed
Apr 28, 2022
projects/vdk-plugins/airflow-provider-vdk/vdk_provider/sensors/vdk.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Gabriel Georgiev <[email protected]>
Signed-off-by: Gabriel Georgiev <[email protected]>
mivanov1988
approved these changes
Apr 28, 2022
| raise VDKJobExecutionException( | ||
| f"Job execution {self.job_execution_id} has been {job_status}." | ||
| ) | ||
| elif ( |
There was a problem hiding this comment.
What if a new status is introduced in the future?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements the poke method of the VDKSensor,
which checks the status of a particular job execution, returns
True if the execution is successful, false if it is not yet complete,
and raises an exception if the job execution has been cancelled,
skipped or has failed.
Also added an exception class for exceptions raised by the poke
method, and dropped vdk-core as a dependency as it is not needed.
Testing done: added 7 unit tests for each status a job execution
can have
Signed-off-by: Gabriel Georgiev [email protected]