vdk-core: new version check built-in plugin false positive fix #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bug detected when using custom new-version-check-plugin configurations: ``` config_builder.set_value(key="PACKAGE_INDEX",value="https://some.repo") config_builder.set_value(key="PACKAGE_NAME", value="some-package-upgraded-to-latest-locally") config_builder.set_value("VERSION_CHECK_PLUGINS", False) ``` That results in false-positive yet package-empty upgrade message displayed: ``` ************************************************************************ New version for is available. Please update to latest version by using: pip install --upgrade-strategy eager -U --extra-index-url https://some.repo ************************************************************************ ``` Changed `_check_version` method to `_print_new_version_message`, matching the purpose described in its pydocs. Added handling of use-case when no packages for upgrade detected. Testing Done: added a `test_no_new_version_check` to cover that use-case, the test detects the issue before the changes and succeeds after applying the changes made. Signed-off-by: ikoleva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug detected when using custom new-version-check-plugin
configurations:
That results in false-positive yet package-empty
upgrade message displayed:
Changed
_check_versionmethod to_print_new_version_message,matching the purpose described in its pydocs. Added handling of
use-case when no packages for upgrade detected.
Testing Done: added a
test_no_new_version_checkto cover thatuse-case, the test detects the issue before the changes
and succeeds after applying the changes made.
Signed-off-by: ikoleva [email protected]