vdk-heartbeat: null datetime conversion fix #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've noticed an occasional error occurs, applying the stack trace: File "/opt/buildenv/lib/python3.7/site-packages/vdk/internal/heartbeat/ job_controller.py", line 383, in check_job_execution_finished self._datetime_from_iso_format(str(e["end_time"])) for e in execution_list TypeError: '>' not supported between instances of 'NoneType' and 'datetime.datetime' The error seems to reproduce in case execution end_time is not yet populated, and `max()` is attempting to compare datetime with NoneType. The fix includes filtering out any empty end_times, so that we rely on statuses and end_times populated only. A broader Exception is added for handling during datetime conversion, like a preventive step. Testing done: did retrieve the Execution API response, did reproduce same TypeError error via local code snippet, then verified the newly introduced fix applied is operational. Signed-off-by: ikoleva <[email protected]>
doks5
reviewed
Apr 20, 2022
We've noticed an occasional error occurs, applying the stack trace: File "/opt/buildenv/lib/python3.7/site-packages/vdk/internal/heartbeat/ job_controller.py", line 383, in check_job_execution_finished self._datetime_from_iso_format(str(e["end_time"])) for e in execution_list TypeError: '>' not supported between instances of 'NoneType' and 'datetime.datetime' The error seems to reproduce in case execution end_time is not yet populated, and `max()` is attempting to compare datetime with NoneType. The fix includes filtering out any empty end_times, so that we rely on statuses and end_times populated only. A broader Exception is added for handling during datetime conversion, like a preventive step. Testing done: did retrieve the Execution API response, did reproduce same TypeError error via local code snippet, then verified the newly introduced fix applied is operational. Signed-off-by: ikoleva <[email protected]>
We've noticed an occasional error occurs, applying the stack trace: File "/opt/buildenv/lib/python3.7/site-packages/vdk/internal/heartbeat/ job_controller.py", line 383, in check_job_execution_finished self._datetime_from_iso_format(str(e["end_time"])) for e in execution_list TypeError: '>' not supported between instances of 'NoneType' and 'datetime.datetime' The error seems to reproduce in case execution end_time is not yet populated, and `max()` is attempting to compare datetime with NoneType. The fix includes filtering out any empty end_times, so that we rely on statuses and end_times populated only. A broader Exception is added for handling during datetime conversion, like a preventive step. Testing done: did retrieve the Execution API response, did reproduce same TypeError error via local code snippet, then verified the newly introduced fix applied is operational. Signed-off-by: ikoleva <[email protected]>
|
Please add a unit test. It's a good idea to add a test(s) that verifies the bug is fixed (they should fail without the fix) -this way |
We have a unit test, that failed - so I did rework and document the workflow considered, Or do you have something else in mind? |
We've noticed an occasional error occurs, applying the stack trace: File "/opt/buildenv/lib/python3.7/site-packages/vdk/internal/heartbeat/ job_controller.py", line 383, in check_job_execution_finished self._datetime_from_iso_format(str(e["end_time"])) for e in execution_list TypeError: '>' not supported between instances of 'NoneType' and 'datetime.datetime' The error seems to reproduce in case execution end_time is not yet populated, and `max()` is attempting to compare datetime with NoneType. The fix presumes the status of latest non-populated `end_time` is freshest, so returns that if present. Otherwise, returns status of latest end datetime populated. Discussion on workflow is found at #813 #discussion_r854317775 A broader Exception is added for handling during datetime conversion, like a preventive step. Testing done: did retrieve the Execution API response, did reproduce same TypeError error via local code snippet, then verified the newly introduced fix applied is operational. Did add a unit test to cover this use-case. Signed-off-by: ikoleva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've noticed an occasional error occurs, applying the stack trace:
File "/opt/buildenv/lib/python3.7/site-packages/vdk/internal/heartbeat/
job_controller.py", line 383, in check_job_execution_finished
self._datetime_from_iso_format(str(e["end_time"])) for e in
execution_list
TypeError: '>' not supported between instances of 'NoneType' and
'datetime.datetime'
The error seems to reproduce in case execution end_time is not yet
populated, and
max()is attempting to compare datetime with NoneType.The fix presumes the status of latest non-populated
end_timeisfreshest, so returns that if present. Otherwise, returns status of
latest end datetime populated. Discussion on workflow is found at
#813 (comment)
A broader Exception is added for handling during datetime conversion,
like a preventive step.
Testing done: did retrieve the Execution API response, did reproduce
same TypeError error via local code snippet, then verified the newly
introduced fix applied is operational. Did add a unit test to cover
this use-case.
Signed-off-by: ikoleva [email protected]