vdk-core: print query duration #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
projects/vdk-core/src/vdk/internal/builtin_plugins/connection/managed_cursor.py
Outdated
Show resolved
Hide resolved
Signed-off-by: mrMoZ1 <[email protected]>
projects/vdk-core/tests/vdk/internal/builtin_plugins/connection/test_managed_cursor.py
Outdated
Show resolved
Hide resolved
projects/vdk-core/src/vdk/internal/builtin_plugins/connection/managed_cursor.py
Outdated
Show resolved
Hide resolved
Signed-off-by: mrMoZ1 <[email protected]>
mrMoZ1
force-pushed
the
person/mzhivkov/sql-timing
branch
from
2195a5c to
7a5e4a3
Compare
Signed-off-by: mrMoZ1 <[email protected]>
for more information, see https://pre-commit.ci
antoniivanov
approved these changes
Apr 15, 2022
antoniivanov
added a commit
that referenced
this pull request
Apr 18, 2022
Currently we cannot track the full execution of a query (before and after it) . This is necessary in order to be able to generate proper lineage events (query start and end) or to track its duration (we had to currently had to add this to vdk-core (#804) but that's really better implemented as plugin (think aspect-oriented programming). In the future we should consider adding hook for fetch (fetchMany, fetchAll) as well as it's there where the data is returned (plugins can take stats - count number of rows, validate sensitive columns, do result validation tests, etc.) Testing Done: unit tests, functional test. Signed-off-by: Antoni Ivanov <[email protected]>
antoniivanov
added a commit
that referenced
this pull request
Apr 18, 2022
Currently we cannot track the full execution of a query (before and after it) . This is necessary in order to be able to generate proper lineage events (query start and end) or to track its duration (we had to currently had to add this to vdk-core (#804) but that's really better implemented as plugin (think aspect-oriented programming). In the future we should consider adding hook for fetch (fetchMany, fetchAll) as well as it's there where the data is returned (plugins can take stats - count number of rows, validate sensitive columns, do result validation tests, etc.) Testing Done: unit tests, functional test. Signed-off-by: Antoni Ivanov <[email protected]>
antoniivanov
added a commit
that referenced
this pull request
May 2, 2022
Currently we cannot track the full execution of a query (before and after it) . This is necessary in order to be able to generate proper lineage events (query start and end) or to track its duration (we had to currently had to add this to vdk-core (#804) but that's really better implemented as plugin (think aspect-oriented programming). In the future we should consider adding hook for fetch (fetchMany, fetchAll) as well as it's there where the data is returned (plugins can take stats - count number of rows, validate sensitive columns, do result validation tests, etc.) Testing Done: unit tests, functional test. Signed-off-by: Antoni Ivanov <[email protected]>
antoniivanov
added a commit
that referenced
this pull request
May 3, 2022
Currently we cannot track the full execution of a query (before and after it) . This is necessary in order to be able to generate proper lineage events (query start and end) or to track its duration (we had to currently had to add this to vdk-core (#804) but that's really better implemented as plugin (think aspect-oriented programming). In the future we should consider adding hook for fetch (fetchMany, fetchAll) as well as it's there where the data is returned (plugins can take stats - count number of rows, validate sensitive columns, do result validation tests, etc.) Testing Done: unit tests, functional test. Signed-off-by: Antoni Ivanov <[email protected]>
antoniivanov
added a commit
that referenced
this pull request
May 4, 2022
Currently we cannot track the full execution of a query (before and after it) . This is necessary in order to be able to generate proper lineage events (query start and end) or to track its duration (we had to currently had to add this to vdk-core (#804) but that's really better implemented as plugin (think aspect-oriented programming). In the future we should consider adding hook for fetch (fetchMany, fetchAll) as well as it's there where the data is returned (plugins can take stats - count number of rows, validate sensitive columns, do result validation tests, etc.) Testing Done: unit tests, functional test. Signed-off-by: Antoni Ivanov <[email protected]>
antoniivanov
added a commit
that referenced
this pull request
May 4, 2022
Currently we cannot track the full execution of a query (before and after it) . This is necessary in order to be able to generate proper lineage events (query start and end) or to track its duration (we had to currently had to add this to vdk-core (#804) but that's really better implemented as plugin (think aspect-oriented programming). In the future we should consider adding hook for fetch (fetchMany, fetchAll) as well as it's there where the data is returned (plugins can take stats - count number of rows, validate sensitive columns, do result validation tests, etc.) Testing Done: unit tests, functional test. Signed-off-by: Antoni Ivanov <[email protected]>
antoniivanov
added a commit
that referenced
this pull request
May 4, 2022
Currently we cannot track the full execution of a query (before and after it) . This is necessary in order to be able to generate proper lineage events (query start and end) or to track its duration (we had to currently had to add this to vdk-core (#804) but that's really better implemented as plugin (think aspect-oriented programming). In the future we should consider adding hook for fetch (fetchMany, fetchAll) as well as it's there where the data is returned (plugins can take stats - count number of rows, validate sensitive columns, do result validation tests, etc.) Testing Done: unit tests, functional test. Signed-off-by: Antoni Ivanov <[email protected]>
antoniivanov
added a commit
that referenced
this pull request
May 4, 2022
Currently we cannot track the full execution of a query (before and after it) . This is necessary in order to be able to generate proper lineage events (query start and end) or to track its duration (we had to currently had to add this to vdk-core (#804) but that's really better implemented as plugin (think aspect-oriented programming). In the future we should consider adding hook for fetch (fetchMany, fetchAll) as well as it's there where the data is returned (plugins can take stats - count number of rows, validate sensitive columns, do result validation tests, etc.) Testing Done: unit tests, functional test. Signed-off-by: Antoni Ivanov <[email protected]>
antoniivanov
added a commit
that referenced
this pull request
May 4, 2022
Currently we cannot track the full execution of a query (before and after it) . This is necessary in order to be able to generate proper lineage events (query start and end) or to track its duration (we had to currently had to add this to vdk-core (#804) but that's really better implemented as plugin (think aspect-oriented programming). In the future we should consider adding hook for fetch (fetchMany, fetchAll) as well as it's there where the data is returned (plugins can take stats - count number of rows, validate sensitive columns, do result validation tests, etc.) Testing Done: unit tests, functional test. Signed-off-by: Antoni Ivanov <[email protected]>
antoniivanov
added a commit
that referenced
this pull request
May 4, 2022
Currently we cannot track the full execution of a query (before and after it) . This is necessary in order to be able to generate proper lineage events (query start and end) or to track its duration (we had to currently had to add this to vdk-core (#804) but that's really better implemented as plugin (think aspect-oriented programming). In the future we should consider adding hook for fetch (fetchMany, fetchAll) as well as it's there where the data is returned (plugins can take stats - count number of rows, validate sensitive columns, do result validation tests, etc.) Testing Done: unit tests, functional test. Signed-off-by: Antoni Ivanov <[email protected]>
antoniivanov
added a commit
that referenced
this pull request
May 21, 2022
Currently we cannot track the full execution of a query (before and after it) . This is necessary in order to be able to generate proper lineage events (query start and end) or to track its duration (we had to currently had to add this to vdk-core (#804) but that's really better implemented as plugin (think aspect-oriented programming). In the future we should consider adding hook for fetch (fetchMany, fetchAll) as well as it's there where the data is returned (plugins can take stats - count number of rows, validate sensitive columns, do result validation tests, etc.) Testing Done: unit tests, functional test. Signed-off-by: Antoni Ivanov <[email protected]>
antoniivanov
added a commit
that referenced
this pull request
Jun 3, 2022
Currently we cannot track the full execution of a query (before and after it) . This is necessary in order to be able to generate proper lineage events (query start and end) or to track its duration (we had to currently had to add this to vdk-core (#804) but that's really better implemented as plugin (think aspect-oriented programming). In the future we should consider adding hook for fetch (fetchMany, fetchAll) as well as it's there where the data is returned (plugins can take stats - count number of rows, validate sensitive columns, do result validation tests, etc.) Testing Done: unit tests, functional test. Signed-off-by: Antoni Ivanov <[email protected]>
antoniivanov
added a commit
that referenced
this pull request
Jun 3, 2022
Currently we cannot track the full execution of a query (before and after it) . This is necessary in order to be able to generate proper lineage events (query start and end) or to track its duration (we had to currently had to add this to vdk-core (#804) but that's really better implemented as plugin (think aspect-oriented programming). In the future we should consider adding hook for fetch (fetchMany, fetchAll) as well as it's there where the data is returned (plugins can take stats - count number of rows, validate sensitive columns, do result validation tests, etc.) Testing Done: unit tests, functional test. Signed-off-by: Antoni Ivanov <[email protected]>
antoniivanov
added a commit
that referenced
this pull request
Jun 3, 2022
Currently we cannot track the full execution of a query (before and after it) . This is necessary in order to be able to generate proper lineage events (query start and end) or to track its duration (we had to currently had to add this to vdk-core (#804) but that's really better implemented as plugin (think aspect-oriented programming). In the future we should consider adding hook for fetch (fetchMany, fetchAll) as well as it's there where the data is returned (plugins can take stats - count number of rows, validate sensitive columns, do result validation tests, etc.) Testing Done: unit tests, functional test. Signed-off-by: Antoni Ivanov <[email protected]>
antoniivanov
added a commit
that referenced
this pull request
Jun 4, 2022
Currently we cannot track the full execution of a query (before and after it) . This is necessary in order to be able to generate proper lineage events (query start and end) or to track its duration (we had to currently had to add this to vdk-core (#804) but that's really better implemented as plugin (think aspect-oriented programming). In the future we should consider adding hook for fetch (fetchMany, fetchAll) as well as it's there where the data is returned (plugins can take stats - count number of rows, validate sensitive columns, do result validation tests, etc.) Testing Done: unit tests, functional test. Signed-off-by: Antoni Ivanov <[email protected]>
antoniivanov
added a commit
that referenced
this pull request
Jun 4, 2022
Currently we cannot track the full execution of a query (before and after it) . This is necessary in order to be able to generate proper lineage events (query start and end) or to track its duration (we had to currently had to add this to vdk-core (#804) but that's really better implemented as plugin (think aspect-oriented programming). In the future we should consider adding hook for fetch (fetchMany, fetchAll) as well as it's there where the data is returned (plugins can take stats - count number of rows, validate sensitive columns, do result validation tests, etc.) Testing Done: unit tests, functional test. Signed-off-by: Antoni Ivanov <[email protected]>
antoniivanov
added a commit
that referenced
this pull request
Jun 4, 2022
Currently we cannot track the full execution of a query (before and after it) . This is necessary in order to be able to generate proper lineage events (query start and end) or to track its duration (we had to currently had to add this to vdk-core (#804) but that's really better implemented as plugin (think aspect-oriented programming). In the future we should consider adding hook for fetch (fetchMany, fetchAll) as well as it's there where the data is returned (plugins can take stats - count number of rows, validate sensitive columns, do result validation tests, etc.) Testing Done: unit tests, functional test. Signed-off-by: Antoni Ivanov <[email protected]>
antoniivanov
added a commit
that referenced
this pull request
Jun 4, 2022
Currently we cannot track the full execution of a query (before and after it) . This is necessary in order to be able to generate proper lineage events (query start and end) or to track its duration (we had to currently had to add this to vdk-core (#804) but that's really better implemented as plugin (think aspect-oriented programming). In the future we should consider adding hook for fetch (fetchMany, fetchAll) as well as it's there where the data is returned (plugins can take stats - count number of rows, validate sensitive columns, do result validation tests, etc.) Testing Done: unit tests, functional test. Signed-off-by: Antoni Ivanov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why: Users requested clearer examples on how long given operations took:
"- In concrete case problems was with SQL query , it would be nice if we can
print profile details (especially if query fails)"
what: Added new log statements that show how long an SQL query took.
testing: Added unit tests.
Signed-off-by: Momchil Zhivkov [email protected]