vdk-impala: unify names of templates betwen trino and impala #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "load/dimension/scd2" is simple implementation of SCD2 which is less optimial and flexible than "load/versioned" which is the recommendd one to use. The "versioned" template correspond to scd2 in vdk-trino plugin for example (vdk-trino/src/vdk/plugin/trino/templates/load/dimension/scd2) . And there there's no scd2_simple implementation at all. So this PR is changing the name of "load/dimension/scd2" to "scd2_simple", It's keeping an alias (alternative) name of "load/dimension/scd2" for backwards compatible reasons. It's also setting as main name of load/versioned to be "scd2" (which is the one used in vdk-trino) Also in vdk-trino Periodic snapshot template is called "periodic_snapshot" so renaming it to match. Testing Done: automated tests Signed-off-by: Antoni Ivanov <[email protected]>
mrMoZ1
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "load/dimension/scd2" is simple implementation of SCD2 which is less
optimial and flexible than "load/versioned" which is the recommendd one
to use.
The "versioned" template correspond to scd2 in vdk-trino plugin for
example (vdk-trino/src/vdk/plugin/trino/templates/load/dimension/scd2) .
And there there's no scd2_simple implementation at all.
So this PR is changing the name of "load/dimension/scd2" to
"scd2_simple", It's keeping an alias (alternative) name of
"load/dimension/scd2" for backwards compatible reasons.
It's also setting as main name of load/versioned to be "scd2" (which is
the one used in vdk-trino)
Also in vdk-trino Periodic snapshot template is called
"periodic_snapshot" so renaming it to match.
Testing Done: automated tests
Signed-off-by: Antoni Ivanov [email protected]