-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VEP-554: Extend Security and Permissions section #786
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniivanov
approved these changes
Apr 6, 2022
antoniivanov
requested changes
Apr 7, 2022
Don't forget to add your name to the Authors section :) |
8d59db8
to
148125a
Compare
antoniivanov
approved these changes
Apr 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks.
As part of the development of the Versatile Data Kit Airflow Provider, we need to ensure that all connections to the Control Service are properly authenticated. For this to happen, we need to define the authentication mechanisms and flows that would be used. This change extends the `Security and Permissions` section of the enhancement proposal to include more details on how authentication would be facilitated in the Airflow Provider. Testing Done: Documentation change, no testing needed. Signed-off-by: Andon Andonov <[email protected]>
Co-authored-by: Gabriel Georgiev <[email protected]>
Co-authored-by: Gabriel Georgiev <[email protected]>
Signed-off-by: Andon Andonov <[email protected]>
148125a
to
d670a60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the development of the Versatile Data Kit Airflow Provider, we need to
ensure that all connections to the Control Service are properly authenticated. For
this to happen, we need to define the authentication mechanisms and flows that would
be used.
This change extends the
Security and Permissions
section of the enhancement proposalto include more details on how authentication would be facilitated in the Airflow Provider.
Testing Done: Documentation change, no testing needed.
Signed-off-by: Andon Andonov [email protected]