control-service: Update Helm chart #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doks5
suggested changes
Aug 12, 2021
projects/control-service/projects/helm_charts/pipelines-control-service/README.md
Show resolved
Hide resolved
projects/control-service/projects/helm_charts/pipelines-control-service/templates/NOTES.txt
Show resolved
Hide resolved
Will do. |
In order to simplify installation of Helm chart some features are disabled by default. The serviceMonitor and alerting are disabled by default. WARNING: When this change is adopted, the respective values must be switched back to true: `metrics.serviceMonitor.enabled` and `alerting.enabled'. The `SPRING_SECURITY_OAUTH2_RESOURCESERVER_JWT_JWK_SET_URI` is not set if the respective jwtJwkSetUri property is empty, to prevent spring security from throwing an exception. Clean up the README file. Update the NOTES.txt file to indicate that the installation will use a public Git repository. The changes are tested by manually installing the Helm chart to a Minikube cluster and verifying that the installation and the service start are successful. Signed-off-by: Tsvetomir Palashki <[email protected]>
tpalashki
force-pushed
the
person/tpalashki/update-helm-chart
branch
from
821ea81 to
575e1b0
Compare
doks5
approved these changes
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to simplify the installation of the Helm chart some
features are disabled by default.
The serviceMonitor and alerting are disabled by default.
WARNING: When this change is adopted, the respective values must
be switched back to true:
metrics.serviceMonitor.enabledand`alerting.enabled'.
The
SPRING_SECURITY_OAUTH2_RESOURCESERVER_JWT_JWK_SET_URIis notset if the respective jwtJwkSetUri property is empty, to prevent
Spring security from throwing an exception.
Clean up the README file. Update the NOTES.txt file to indicate
that the installation will use a public Git repository.
Signed-off-by: Tsvetomir Palashki [email protected]