Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

control-service: Set TTLAfterFinished period for K8s CronJobs #776

Merged
merged 5 commits into from
Mar 23, 2022

Conversation

gabrielgeorgiev1
Copy link
Contributor

To take advantage of the automatic jobs cleanup afforded by
the TTL Controller, we need to the the TTLAfterFinished setting
to some appropriate value. Here, we've chosen 1 hour.

Testing done: TBD

Signed-off-by: Gabriel Georgiev [email protected]

@antoniivanov
Copy link
Collaborator

Please make it conifgurable .

Signed-off-by: Gabriel Georgiev <[email protected]>
@gabrielgeorgiev1 gabrielgeorgiev1 marked this pull request as ready for review March 23, 2022 10:33
Signed-off-by: Gabriel Georgiev <[email protected]>
Signed-off-by: Gabriel Georgiev <[email protected]>
Signed-off-by: Gabriel Georgiev <[email protected]>
@gabrielgeorgiev1 gabrielgeorgiev1 merged commit 2d46077 into main Mar 23, 2022
@gabrielgeorgiev1 gabrielgeorgiev1 deleted the person/gageorgiev/cs-integration branch March 23, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants