[vdk-core][vdk-control-cli] Adopt click version 8.0 #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, Versatile Data Kit uses click version 7.X in vdk-core and vdk-control-cli, due to an issue of flag values not being converted to enum, but rather to string. This change adopts click 8.X and fixes the issues with click flag values by always using strings and string representations of enum values where comparisons are needed. Testing Done: unit tests Signed-off-by: Andon Andonov <[email protected]>
mivanov1988
approved these changes
Mar 17, 2022
ivakoleva
added a commit
that referenced
this pull request
Mar 17, 2022
Did notice a conflict: ``` The conflict is caused by: vdk-control-cli 1.2.494451234 depends on click==7.* vdk-core 0.1.494451234 depends on click==8.* ``` A follow-up to #769 Updated a pinned version from 7.* to 8.* Testing Done: ci/cd Signed-off-by: ikoleva <[email protected]>
ivakoleva
added a commit
that referenced
this pull request
Mar 17, 2022
Did notice a conflict: ``` The conflict is caused by: vdk-control-cli 1.2.494451234 depends on click==7.* vdk-core 0.1.494451234 depends on click==8.* ``` A follow-up to #769 Updated a pinned version from 7.* to 8.* Testing Done: ci/cd Signed-off-by: ikoleva <[email protected]>
ivakoleva
added a commit
that referenced
this pull request
Mar 17, 2022
* vdk-control-cli: Adopt click version 8 Did notice a conflict: ``` The conflict is caused by: vdk-control-cli 1.2.494451234 depends on click==7.* vdk-core 0.1.494451234 depends on click==8.* ``` A follow-up to #769 Updated a pinned version from 7.* to 8.* Testing Done: ci/cd Signed-off-by: ikoleva <[email protected]>
ivakoleva
pushed a commit
that referenced
this pull request
Mar 22, 2022
Currently, Versatile Data Kit uses click version 7.X in vdk-core and vdk-control-cli, due to an issue of flag values not being converted to enum, but rather to string. This change adopts click 8.X and fixes the issues with click flag values by always using strings and string representations of enum values where comparisons are needed. Testing Done: unit tests Signed-off-by: Andon Andonov <[email protected]>
ivakoleva
added a commit
that referenced
this pull request
Mar 22, 2022
* vdk-control-cli: Adopt click version 8 Did notice a conflict: ``` The conflict is caused by: vdk-control-cli 1.2.494451234 depends on click==7.* vdk-core 0.1.494451234 depends on click==8.* ``` A follow-up to #769 Updated a pinned version from 7.* to 8.* Testing Done: ci/cd Signed-off-by: ikoleva <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Versatile Data Kit uses click version 7.X in vdk-core and
vdk-control-cli, due to an issue of flag values not being converted to
enum, but rather to string.
This change adopts click 8.X and fixes the issues with click flag values by
always using strings and string representations of enum values where comparisons
are needed.
Testing Done: unit tests
Signed-off-by: Andon Andonov [email protected]