[helm-chart]: add kerberos auth properties to helm chart #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrMoZ1
changed the title
antoniivanov
requested changes
Mar 11, 2022
projects/control-service/projects/helm_charts/pipelines-control-service/values.yaml
Outdated
Show resolved
Hide resolved
projects/control-service/projects/helm_charts/pipelines-control-service/values.yaml
Outdated
Show resolved
Hide resolved
projects/control-service/projects/helm_charts/pipelines-control-service/values.yaml
Outdated
Show resolved
Hide resolved
added 2 commits
March 16, 2022 11:44
Signed-off-by: mrMoZ1 <[email protected]>
Signed-off-by: mrMoZ1 <[email protected]>
mrMoZ1
force-pushed
the
person/mzhivkov/krb-security-values
branch
from
05641e5 to
73fbc7e
Compare
ivakoleva
requested changes
Mar 17, 2022
projects/control-service/projects/helm_charts/pipelines-control-service/values.yaml
Outdated
Show resolved
Hide resolved
...control-service/projects/pipelines_control_service/src/main/resources/application.properties
Show resolved
Hide resolved
...control-service/projects/pipelines_control_service/src/main/resources/application.properties
Show resolved
Hide resolved
...control-service/projects/pipelines_control_service/src/main/resources/application.properties
Outdated
Show resolved
Hide resolved
...control-service/projects/pipelines_control_service/src/main/resources/application.properties
Outdated
Show resolved
Hide resolved
|
On #764 (comment) and #764 (comment) |
added 2 commits
March 17, 2022 13:54
Signed-off-by: mrMoZ1 <[email protected]>
Signed-off-by: mrMoZ1 <[email protected]>
projects/control-service/projects/helm_charts/pipelines-control-service/values.yaml
Show resolved
Hide resolved
antoniivanov
approved these changes
Mar 18, 2022
ivakoleva
approved these changes
Mar 21, 2022
projects/control-service/projects/helm_charts/pipelines-control-service/values.yaml
Outdated
Show resolved
Hide resolved
service principal and keytab docs elaborated. Signed-off-by: ikoleva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what: Added new properties to the helm chart as requested here:
#755 (comment)
The new properties expose kerberos authentication configuration properties
in the helm chart which are propagated to control-service.
why: We are introducing a new KerberosAuthProvider in control-service
and we need to expose configuration properties through the helm chart.
testing: Deployed on local minikube cluster. Made sure secret is created
and populated with correct files. Inspected control-service pods, made sure
the new env variables are present and that secrets exist.
Signed-off-by: Momchil Zhivkov [email protected]