control-service: Adopt kubernetes-client 14.0.1 #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriel Georgiev <[email protected]>
Signed-off-by: Gabriel Georgiev <[email protected]>
…on/gageorgiev/jobs-cleanup
Signed-off-by: Gabriel Georgiev <[email protected]>
Signed-off-by: Gabriel Georgiev <[email protected]>
antoniivanov
approved these changes
Mar 10, 2022
As we need to support both older and newer versions of CronJob it's not straight up replacement, right? |
antoniivanov
pushed a commit
that referenced
this pull request
Mar 16, 2022
To take advantage of the V1CronJob API and enable automatic job cleanup for the builder jobs and manually executed data jobs, we need to adopt the latest version of kubernetes-client. Further steps are replacing the currently used CronJob object with the new V1CronJob, and including the TTL parameter for builder jobs and manually executed data jobs. Testing done: project builds successfully and unittests pass Signed-off-by: Gabriel Georgiev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To take advantage of the V1CronJob API and enable automatic
job cleanup for the builder jobs and manually executed data jobs,
we need to adopt the latest version of kubernetes-client.
Further steps are replacing the currently used CronJob object
with the new V1CronJob, and including the TTL parameter for
builder jobs and manually executed data jobs.
Testing done: project builds successfully and unittests pass
Signed-off-by: Gabriel Georgiev [email protected]