Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

control-service: CI/CD improvements #76

Merged

Conversation

mivanov1988
Copy link
Collaborator

Enabled publishing of docker and helm artifacts.

Testing Done: pull request CICD.

Signed-off-by: Miroslav Ivanov [email protected]

@mivanov1988 mivanov1988 force-pushed the person/miroslavi/control-service-cicd-improvements branch 15 times, most recently from faf3f51 to 4babf99 Compare August 11, 2021 15:15
Copy link
Contributor

@doks5 doks5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI/CD has failed due to permissions error.

@mivanov1988 mivanov1988 force-pushed the person/miroslavi/control-service-cicd-improvements branch 8 times, most recently from e329c5b to 3eebe6a Compare August 12, 2021 13:42
Enabled publishing of docker and helm artifacts.

Testing Done: pull request CICD.

Signed-off-by: Miroslav Ivanov [email protected]
@mivanov1988 mivanov1988 force-pushed the person/miroslavi/control-service-cicd-improvements branch from 3eebe6a to 128fdc3 Compare August 12, 2021 13:52
@mivanov1988
Copy link
Collaborator Author

The CI/CD has failed due to permissions error.

Where did you see that?

@mivanov1988 mivanov1988 requested a review from doks5 August 12, 2021 14:34
@doks5
Copy link
Contributor

doks5 commented Aug 12, 2021

The CI/CD has failed due to permissions error.

Where did you see that?

I think it was this job https://gitlab.com/vmware-analytics/versatile-data-kit/-/jobs/1495980672
But it seems to have been fixed, so it's no longer an issue.

@mivanov1988 mivanov1988 merged commit 7f7bfd7 into main Aug 12, 2021
@mivanov1988 mivanov1988 deleted the person/miroslavi/control-service-cicd-improvements branch August 12, 2021 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants