vdk-heartbeat: Fix initial job executions with specific vdk version #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When vdk-heartbeat is run with a configured vdk version (VDK_HEARTBEAT_DEPLOY_JOB_VDK_VERSION) sometimes the cron job manages to start an execution before actually setting the deployment vdk_version. This happens because vdk_version is set with a separate update deployment call (function enable_deployment_and_update_vdk_version) after the deployment was ready. Move setting vdk_version in the create deployment command. Testing Done: locally tested vdk-heartbeat against demo control service with set VDK_HEARTBEAT_DEPLOY_JOB_VDK_VERSION and observed that all execution pods used the specified vdk version image. Signed-off-by: Yana Zhivkova <[email protected]>
antoniivanov
approved these changes
Mar 9, 2022
YanaZhivkova
deleted the
person/yzhivkova/Fix_vdk-heartbeat_custom_vdk_version_executions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When vdk-heartbeat is run with a configured vdk version
(VDK_HEARTBEAT_DEPLOY_JOB_VDK_VERSION) sometimes the cron job
manages to start an execution before actually setting the
deployment vdk_version. This happens because vdk_version is
set with a separate update deployment
call (function enable_deployment_and_update_vdk_version)
after the deployment was ready.
Move setting vdk_version in the create deployment command.
Testing Done: locally tested vdk-heartbeat against demo
control service with set VDK_HEARTBEAT_DEPLOY_JOB_VDK_VERSION
and observed that all execution pods used the specified
vdk version image.
Signed-off-by: Yana Zhivkova [email protected]