vdk-control-cli: set vdk version and enabled when deploying new job #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we cannot create new deployment and at the same time enable it or set other vdk version in a single operation. This means we have to do it in two different cli calls which may create race condition (where job deployment starts with previous configuration before new is applied) In this change we enable passing --vdk-version and --enabled when creating deployment with vdk deploy --create e.g ``` vdk deploy --create --vdk-version 1.2 --disabled ``` would create a new deplloyment which uses vdk version 1.2 and is disabled. Testing Done: automated tests included Signed-off-by: Antoni Ivanov <[email protected]>
antoniivanov
force-pushed
the
person/aivanov/vdk-control-cli-create
branch
from
b59d09d to
9577eed
Compare
projects/vdk-control-cli/tests/vdk/internal/control/command_groups/job/test_deploy.py
Outdated
Show resolved
Hide resolved
…oups/job/test_deploy.py Co-authored-by: Gabriel Georgiev <[email protected]>
YanaZhivkova
approved these changes
Mar 7, 2022
projects/vdk-control-cli/src/vdk/internal/control/command_groups/job/deploy_cli.py
Show resolved
Hide resolved
antoniivanov
commented
Mar 7, 2022
projects/vdk-control-cli/tests/vdk/internal/control/command_groups/job/test_deploy.py
Outdated
Show resolved
Hide resolved
…oups/job/test_deploy.py
antoniivanov
added a commit
that referenced
this pull request
Mar 16, 2022
…752) * vdk-control-cli: set vdk version and enabled when deploying new job Currently, we cannot create a new deployment and at the same time enable it or set another vdk version in a single operation. This means we have to do it in two different cli calls which may create race condition (where job deployment starts with the previous configuration before new is applied) In this change we enable passing --vdk-version and --enabled when creating deployment with vdk deploy --create e.g ``` vdk deploy --create --vdk-version 1.2 --disabled ``` would create a new deployment which uses vdk version 1.2 and is disabled. Testing Done: automated tests included Signed-off-by: Antoni Ivanov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we cannot create new deployment and at the same time enable it
or set other vdk version in a single operation. This means we have to do
it in two different cli calls which may create race condition (where job
deployment starts with previous configuration before new is applied)
In this change we enable passing --vdk-version and --enabled when
creating deployment
with vdk deploy --create e.g
would create a new deplloyment which uses vdk version 1.2 and is
disabled.
Testing Done: automated tests included
Signed-off-by: Antoni Ivanov [email protected]