vdk-heartbeat: Handle execution end_time not string #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can you describe in a bit more details with example? Why would not be a string (I guess it can be None). |
antoniivanov
reviewed
Mar 1, 2022
projects/vdk-heartbeat/src/vdk/internal/heartbeat/job_controller.py
Outdated
Show resolved
Hide resolved
doks5
force-pushed
the
person/andonova/fix-heartbeat-bug
branch
from
aa986b3 to
6b7b79e
Compare
I've added a clarification. |
antoniivanov
reviewed
Mar 1, 2022
antoniivanov
reviewed
Mar 1, 2022
projects/vdk-heartbeat/src/vdk/internal/heartbeat/job_controller.py
Outdated
Show resolved
Hide resolved
doks5
force-pushed
the
person/andonova/fix-heartbeat-bug
branch
2 times, most recently
from
6c0994a to
646de0b
Compare
antoniivanov
reviewed
Mar 7, 2022
projects/vdk-heartbeat/src/vdk/internal/heartbeat/job_controller.py
Outdated
Show resolved
Hide resolved
doks5
force-pushed
the
person/andonova/fix-heartbeat-bug
branch
2 times, most recently
from
ef432e7 to
0661318
Compare
antoniivanov
reviewed
Mar 8, 2022
projects/vdk-heartbeat/src/vdk/internal/heartbeat/job_controller.py
Outdated
Show resolved
Hide resolved
doks5
force-pushed
the
person/andonova/fix-heartbeat-bug
branch
from
0661318 to
d21d56c
Compare
antoniivanov
approved these changes
Mar 8, 2022
doks5
force-pushed
the
person/andonova/fix-heartbeat-bug
branch
from
d21d56c to
e18b96b
Compare
antoniivanov
reviewed
Mar 8, 2022
projects/vdk-heartbeat/src/vdk/internal/heartbeat/job_controller.py
Outdated
Show resolved
Hide resolved
doks5
force-pushed
the
person/andonova/fix-heartbeat-bug
branch
from
e18b96b to
965da04
Compare
Currently, if for some reason the `end_time` field of the execution object is not a string (for example, the value is `None`), the `datetime.fromisoformat()` method throws an exception and fails the heartbeat test. This change introduces an explicit conversion of the value to string and adds logging for what the error is along with indication that the heartbeat will fail. Testing Done: Unit tests added. Signed-off-by: Andon Andonov <[email protected]>
doks5
force-pushed
the
person/andonova/fix-heartbeat-bug
branch
from
965da04 to
2beff60
Compare
antoniivanov
pushed a commit
that referenced
this pull request
Mar 16, 2022
Currently, if for some reason the `end_time` field of the execution object is not a string (for example, the value is `None`), the `datetime.fromisoformat()` method throws an exception and fails the heartbeat test. This change introduces an explicit conversion of the value to string and adds logging for what the error is along with indication that the heartbeat will fail. Testing Done: Unit tests added. Signed-off-by: Andon Andonov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if for some reason the
end_timefield of the execution objectis not a string (for example, the value is
None), thedatetime.fromisoformat()method throws an exception and fails the heartbeat test.
This change introduces an explicit conversion of the value to string and adds
logging for what the error is along with indication that the heartbeat will fail.
Testing Done: Unit tests added.
Signed-off-by: Andon Andonov [email protected]