vdk-core: ensure sql args are subsituted in correct priority #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivakoleva
approved these changes
Mar 1, 2022
The documented order is that get_property API is lower priority over get_arguments API. But it was not working, properties were taking precedence instead. This was not well explained in execute_query API as well. This was fixed in this change and new tests are added. Testing Done: extended functional tests. Signed-off-by: Antoni Ivanov <[email protected]>
antoniivanov
force-pushed
the
person/aivanov/vdk-core-args-test2
branch
from
4423290 to
e4b9b74
Compare
antoniivanov
added a commit
that referenced
this pull request
Mar 16, 2022
The documented order is that get_property API is lower priority over get_arguments API. But it was not working, properties were taking precedence instead. This was not well explained in execute_query API as well. This was fixed in this change and new tests are added. Testing Done: extended functional tests. Signed-off-by: Antoni Ivanov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documented order is that get_property API is lower priority over
get_arguments API. But it was not working, properties were taking
precedence instead. This was not well explained in execute_query API as
well.
This was fixed in this change and new tests are added.
Testing Done: extended functional tests.
Signed-off-by: Antoni Ivanov [email protected]