Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdk-core: refactor test to use job_path method #747

Merged
merged 2 commits into from
Mar 2, 2022

Conversation

antoniivanov
Copy link
Collaborator

job_path is shorter version to get the jobs path in test in vdk-core

Signed-off-by: Antoni Ivanov [email protected]

job_path is shorter version to get the jobs path in test in vdk-core

Signed-off-by: Antoni Ivanov <[email protected]>
@antoniivanov antoniivanov enabled auto-merge (squash) March 1, 2022 14:47
Copy link
Contributor

@ivakoleva ivakoleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see other def job_path implementations, that would evaluate get_test_job_path, only substituting the __file__ where the function is defined.

I would suggest, instead of defining multiple job_path functions per each package (for example functional.run in this particular case), to introduce a common job_path method, that considers the location relatively to the actual caller file location - in favour of __file__ of definition.

@antoniivanov
Copy link
Collaborator Author

I can see other def job_path implementations, that would evaluate get_test_job_path, only substituting the __file__ where the function is defined.

I would suggest, instead of defining multiple job_path functions per each package (for example functional.run in this particular case), to introduce a common job_path method, that considers the location relatively to the actual caller file location - in favour of __file__ of definition.

I will consider re-implementing util.job_path to be more generic in separate PR. But let's merge this first.

@antoniivanov antoniivanov requested a review from ivakoleva March 2, 2022 10:04
@antoniivanov antoniivanov merged commit 45af73e into main Mar 2, 2022
@antoniivanov antoniivanov deleted the person/aivanov/vdk-core-args-test branch March 2, 2022 14:09
antoniivanov added a commit that referenced this pull request Mar 16, 2022
job_path is shorter version to get the jobs path in test in vdk-core

Signed-off-by: Antoni Ivanov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants