vdk-core: JobInput get_name and get_job_directory implementation #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The IJobInput get_name and get_job_directory methods were not implemented. Yet, we need to utilize those capabilities. Extended JobInput instantiation performed by job_context.py. Since modifying the JobInput constructor parameters, did unify with JobContext constructor params convention (since params matching). Testing Done: added unit tests for name and job directory propagation; added functional test for verifying the name and directory retrieved; adjusted test_substitute_query_params.py to extended JobInput params. Signed-off-by: ikoleva <[email protected]>
antoniivanov
approved these changes
Mar 1, 2022
The IJobInput get_name and get_job_directory methods were not implemented. Yet, we need to utilize those capabilities. Extended JobInput instantiation performed by job_context.py. Since modifying the JobInput constructor parameters, did unify with JobContext constructor params convention (since params matching). Testing Done: added unit tests for name and job directory propagation; added functional test for verifying the name and directory retrieved; adjusted test_substitute_query_params.py to extended JobInput params. Signed-off-by: ikoleva <[email protected]>
antoniivanov
pushed a commit
that referenced
this pull request
Mar 16, 2022
* vdk-core: JobInput get_name and get_job_directory implementation The IJobInput get_name and get_job_directory methods were not implemented. Yet, we need to utilize those capabilities. Extended JobInput instantiation performed by job_context.py. Since modifying the JobInput constructor parameters, did unify with JobContext constructor params convention (since params matching). Testing Done: added unit tests for name and job directory propagation; added functional test for verifying the name and directory retrieved; adjusted test_substitute_query_params.py to extended JobInput params. Signed-off-by: ikoleva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IJobInput get_name and get_job_directory methods were not
implemented. Yet, we need to utilize those capabilities.
Extended JobInput instantiation performed by job_context.py.
Since modifying the JobInput constructor parameters, did unify with
JobContext constructor params convention (since params matching).
Testing Done: added unit tests for name and job directory propagation;
added functional test for verifying the name and directory retrieved;
adjusted test_substitute_query_params.py to extended JobInput params.
Signed-off-by: ikoleva [email protected]