vdk-kerberos-auth: upgrade minikerberos and requests-kerberos to latest #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issues were noticed with python >3.7 with requests-kerberos configured hostname. The minikerberos dependency was pinned to 0.1.0 - due to interface changes introduced in later versions. We need to upgrade to the latest, so we solve issues fixed in later dependency versions. Unpinned minikerberos and requests-kerberos versions, using effectively: minikerberos 0.2.17 requests-kerberos 0.14.0 Introduced VdkAioKerberosClient implementation, based on minikerberos AIOKerberosClient, that patches two issues marked with a comment. We will elaborate further on potentially contributing the fixes back to minikerberos. Testing Done: did install locally and run an authentication successfully using a keytab and KDC server available. Signed-off-by: ikoleva <[email protected]>
Issues were noticed with python >3.7 with requests-kerberos configured hostname. The minikerberos dependency was pinned to 0.1.0 - due to functional changes introduced in later versions. We need to upgrade to the latest, so we solve issues fixed in later dependency versions. Unpinned minikerberos and requests-kerberos versions, using effectively: minikerberos 0.2.17 requests-kerberos 0.14.0 Testing Done: did install locally and run an authentication successfully using a keytab and KDC server available. Signed-off-by: ikoleva <[email protected]>
doks5
suggested changes
Feb 25, 2022
There was a problem hiding this comment.
There seems to be missing changes, https://gitlab.com/vmware-analytics/versatile-data-kit/-/jobs/2137464316#L427
projects/vdk-plugins/vdk-kerberos-auth/src/vdk/plugin/kerberos/vdk_kerberos_client.py
Show resolved
Hide resolved
projects/vdk-plugins/vdk-kerberos-auth/src/vdk/plugin/kerberos/vdk_kerberos_client.py
Show resolved
Hide resolved
projects/vdk-plugins/vdk-kerberos-auth/src/vdk/plugin/kerberos/vdk_kerberos_client.py
Show resolved
Hide resolved
|
Are the introduced changes covered by existing tests? If not we should think about testing. |
tests cover the change; |
mrMoZ1
approved these changes
Feb 25, 2022
doks5
approved these changes
Feb 25, 2022
antoniivanov
pushed a commit
that referenced
this pull request
Mar 16, 2022
…st (#742) * vdk-kerberos-auth: upgrade minikerberos and requests-kerberos to latest Issues were noticed with python >3.7 with requests-kerberos configured hostname. The minikerberos dependency was pinned to 0.1.0 - due to functional changes introduced in later versions. We need to upgrade to the latest, so we solve issues fixed in later dependency versions. Unpinned minikerberos and requests-kerberos versions, using effectively: minikerberos 0.2.17 requests-kerberos 0.14.0 Introduced VdkAioKerberosClient implementation, based on minikerberos AIOKerberosClient, that patches two issues marked with a comment. We will elaborate further on potentially contributing the fixes back to minikerberos. Testing Done: did install locally and run an authentication successfully using a keytab and KDC server available. Signed-off-by: ikoleva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues were noticed with python >3.7 with requests-kerberos configured
hostname. The minikerberos dependency was pinned to 0.1.0 - due to
functional changes introduced in later versions. We need to upgrade to
the latest, so we solve issues fixed in later dependency versions.
Unpinned minikerberos and requests-kerberos versions, using effectively:
minikerberos 0.2.17
requests-kerberos 0.14.0
Introduced VdkAioKerberosClient implementation, based on minikerberos
AIOKerberosClient, that patches two issues marked with a comment.
We will elaborate further on potentially contributing the fixes back to
minikerberos.
Testing Done: did install locally and run an authentication successfully
using a keytab and KDC server available.
Signed-off-by: ikoleva [email protected]