control-service: fix log link to set endTime always #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case the job is not finished, there's no end time (logically) but VMware Log Insight links do not work if no endTime is set. That might be problem for other engines. It's better to set it to current time instead of leaving empty. I was wondering if I should set it to 1 hour in the future. But uses can use endOffset option to change this. And there's chance that some Log services may not work well with "future" times. Testing Done: unit tests Signed-off-by: Antoni Ivanov <[email protected]>
antoniivanov
force-pushed
the
person/aivanov/control-service-time
branch
from
4910ef4 to
1f82c59
Compare
mivanov1988
reviewed
Feb 23, 2022
...ol_service/src/main/java/com/vmware/taurus/service/execution/JobExecutionLogsUrlBuilder.java
Show resolved
Hide resolved
mivanov1988
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the job is not finished, there's no end time (logically) but
VMware Log Insight links do not work if no endTime is set. That might be
problem for other engines.
It's better to set it to current time instead of leaving empty.
I was wondering if I should set it to 1 hour in the future. But uses can
use endOffset option to change this. And there's chance that some Log
services may not work well with "future" times.
Testing Done: unit tests
Signed-off-by: Antoni Ivanov [email protected]