-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vdk: add VDK enhancement proposal (VEP) spec template #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c200d6a
to
ebb103b
Compare
mivanov1988
reviewed
Feb 23, 2022
doks5
reviewed
Feb 24, 2022
doks5
reviewed
Feb 24, 2022
672e8c2
to
90fdd91
Compare
ivakoleva
reviewed
Feb 24, 2022
c893e39
to
eb4e964
Compare
As we are implementing more complex features we need a clear and easy process to make feature proposals. Here we are adding a spec template. It is heaviy influenced by VMware development best practices and [Kubernetes KEPs](github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template) and [Python PEPs](https://www.python.org/dev/peps). Signed-off-by: Antoni Ivanov <[email protected]>
eb4e964
to
6fd8fa4
Compare
mivanov1988
approved these changes
Mar 21, 2022
I will merge this now. Please feel free to make comments. I will address them in subsequent PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we are implementing more complex features we need a clear and easy
process to make feature proposals.
Overall the goals of the VDK Enhancement Proposal specs are:
Here we are adding a spec template. It is heavily influenced by VMware
development best practices and Kubernetes
KEPs
and Python PEPs.
You can see an example at #730
Signed-off-by: Antoni Ivanov [email protected]