vdk-ingest-http: configurable allow JSON float NaN capability #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on requests encoder/decoder default configuration, simplejson/json is used to handle a specification compliant JSON by default. We need a configurable allow NaN capability, so that when enabled, ingestion payload NaN values are parsed correctly - instead raising ValueError interrupting the ingestion. Introduced `INGEST_OVER_HTTP_ALLOW_NAN` plugin configuration, that is set to False by default. Testing Done: did add `test_ingest_over_http_json_dumps_parameters_propagation` that verifies `INGEST_OVER_HTTP_ALLOW_NAN` configuration propagation to `json.dumps` Signed-off-by: ikoleva <[email protected]>
doks5
suggested changes
Feb 21, 2022
projects/vdk-plugins/vdk-ingest-http/src/vdk/plugin/ingest_http/ingest_http_plugin.py
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-ingest-http/src/vdk/plugin/ingest_http/ingest_over_http.py
Show resolved
Hide resolved
doks5
suggested changes
Feb 21, 2022
Based on requests encoder/decoder default configuration, simplejson/json is used to handle a specification compliant JSON by default. We need a configurable allow NaN capability, so that when enabled, ingestion payload NaN values are parsed correctly - instead raising ValueError interrupting the ingestion. Introduced `INGEST_OVER_HTTP_ALLOW_NAN` plugin configuration, that is set to False by default. Testing Done: did add `test_ingest_over_http_json_dumps_parameters_propagation` that verifies `INGEST_OVER_HTTP_ALLOW_NAN` configuration propagation to `json.dumps` Signed-off-by: ikoleva <[email protected]>
doks5
approved these changes
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on requests encoder/decoder default configuration, simplejson/json
is used to handle a specification compliant JSON by default. We need a
configurable allow NaN capability, so that when enabled, ingestion
payload NaN values are parsed correctly - instead raising ValueError
interrupting the ingestion.
Introduced
INGEST_OVER_HTTP_ALLOW_NANplugin configuration, that isset to False by default.
Testing Done: did add
test_ingest_over_http_json_dumps_parameters_propagationthat verifiesINGEST_OVER_HTTP_ALLOW_NANconfiguration propagation tojson.dumpsSigned-off-by: ikoleva [email protected]