Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vdk-heartbeat] Fix successful run status check #724

Merged
merged 1 commit into from
Feb 21, 2022
Merged

[vdk-heartbeat] Fix successful run status check #724

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions projects/vdk-heartbeat/src/vdk/internal/heartbeat/successful_run_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ def clean_up(self):
@LogDecorator(log)
def execute_test(self):
status = None
success_status = "succeeded"
try:
status = self.__job_controller.check_job_execution_finished()
except Exception as e:
Expand All @@ -40,10 +41,10 @@ def execute_test(self):
f"successfully. However the job did not do it in time. "
f"Check data job logs for possible errors."
)
if status != "success":
if status != success_status:
raise AssertionError(
"Successful run test failed with unexpected data job status. "
f"It was waiting for data job {self.config.job_name} to complete "
f"with status 'success'. However the job completed with status {status}. "
f"with status '{success_status}'. However the job completed with status {status}. "
f"Check the data job logs for errors."
)