[vdk-kerberos-auth] Fix keytab file in job directory #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielgeorgiev1
approved these changes
Feb 21, 2022
There was a problem hiding this comment.
You may want to review any jobs which use keytab files and make sure that their keytab is located outside the job directory. This includes non-github repos as well (I have some memory where I placed a test job's keytab inside the job dir, this is why I'm mentioning this).
ivakoleva
approved these changes
Feb 21, 2022
doks5
force-pushed
the
person/andonova/keytabfile-bug
branch
3 times, most recently
from
82deacb to
ed17798
Compare
Currently, if a `VDK_KEYTAB_FOLDER` is not specified, the kerberos plugin looks for the keytab file in the data job directory, which causes operation conflict between the `vdk run` and `vdk deploy` commands. `vdk run` looks for the keytab file in the job's directory and throws an exception if the file is not there, while `vdk deploy` checks that there IS NO keytab file in the job's directory, and throws an exception if there is such a file in the directory. This change ensures that if `VDK_KEYTAB_FOLDER` is not set, the default directory to look for a keytab file would be the data job's parent directory. Testing Done: moved the keytab file used in functional tests outside the test job directory. Signed-off-by: Andon Andonov <[email protected]>
doks5
force-pushed
the
person/andonova/keytabfile-bug
branch
from
ed17798 to
f57c38c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if a
VDK_KEYTAB_FOLDERis not specified, the kerberos pluginlooks for the keytab file in the data job directory, which causes operation
conflict between the
vdk runandvdk deploycommands.vdk runlooks for the keytab file in the job's directory and throws an exceptionif the file is not there, while
vdk deploychecks that there IS NO keytab file in the job's directory, and throwsan exception if there is such a file in the directory.
This change ensures that if
VDK_KEYTAB_FOLDERis not set, the default directory tolook for a keytab file would be the data job's parent directory.
Testing Done: moved the keytab file used in functional tests outside the test job directory.
Signed-off-by: Andon Andonov [email protected]