vdk-heartbeat: Successful data job run test mode #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The util was missing a simple test, that verifies the (custom or not) data job has run once and succeeded. Introduced `successful_run_test.py`. Elaborated on `job_controller.py` to return the data job status on `check_job_execution_finished`. Fixed a controller bug - in case no executions were present, the flag was still set to `job_execution_running = False`. Testing Done: did verify locally the filtering of latest_end_date and retrieving the status based on execution list data. Signed-off-by: ikoleva <[email protected]>
doks5
approved these changes
Feb 19, 2022
| status = None | ||
| try: | ||
| status = self.__job_controller.check_job_execution_finished() | ||
| except Exception as e: |
There was a problem hiding this comment.
Exception object seems not used. Maybe log the exception before raising the AssertionError?
| time.sleep(10) | ||
| log.info(f"Data job is running : {job_execution_running}") | ||
| assert not job_execution_running, ( | ||
| f"VDK-heartbeat timed out. Job execution {self.config.job_name} " | ||
| + f"did not finish in {self.config.RUN_TEST_TIMEOUT_SECONDS}." | ||
| ) | ||
| if not execution_list: | ||
| return None | ||
| latest_end_date = max( |
There was a problem hiding this comment.
nit: Maybe add a blank line, as now it feels a bit crowded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The util was missing a simple test, that verifies the (custom or not)
data job has run once and succeeded.
Introduced
successful_run_test.py. Elaborated onjob_controller.pyto return the data job status on
check_job_execution_finished.Fixed a controller bug - in case no executions were present, the flag
was still set to
job_execution_running = False.Testing Done: did verify locally the filtering of latest_end_date
and retrieving the status based on execution list data.
Signed-off-by: ikoleva [email protected]