control-service: add job-base-image folder and CI step/job #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniivanov
added a commit
that referenced
this pull request
Feb 16, 2022
This is legacy builder which has been replaced by [job-builder](https://github.com/vmware/versatile-data-kit/tree/main/projects/control-service/projects/job-builder) and [job-builder-rootless](https://github.com/vmware/versatile-data-kit/tree/main/projects/control-service/projects/job-builder-rootless) so it is no longer necessary. The only leftover was the building of hte job base image which is moved in #711 Testing Done: trivial, CI will verify if I've missed something Signed-off-by: Antoni Ivanov <[email protected]>
antoniivanov
force-pushed
the
person/aivanov/control-service-base-image
branch
2 times, most recently
from
52cd704 to
c70028d
Compare
antoniivanov
added a commit
that referenced
this pull request
Feb 17, 2022
This is legacy builder which has been replaced by [job-builder](https://github.com/vmware/versatile-data-kit/tree/main/projects/control-service/projects/job-builder) and [job-builder-rootless](https://github.com/vmware/versatile-data-kit/tree/main/projects/control-service/projects/job-builder-rootless) so it is no longer necessary. The only leftover was the building of hte job base image which is moved in #711 Testing Done: trivial, CI will verify if I've missed something Signed-off-by: Antoni Ivanov <[email protected]>
mivanov1988
approved these changes
Feb 17, 2022
Currently the building of the data job base image was not done by our CICD and was left in the older builder folder (vdk_job_builder). This means that if there were changes to teh base image we'd need to rebuild it manually (and not part of CI) which is not good. After this change I'd completely delete vdk_job_builder which no longer needed for anything. Testing Done: this PR (the commit was edited to allow to run on PR , at the end the CI job will run only in main) Signed-off-by: Antoni Ivanov <[email protected]>
antoniivanov
force-pushed
the
person/aivanov/control-service-base-image
branch
from
f597427 to
becc3b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the building of the data job base image was not done by our
CICD and was left in the older builder folder (vdk_job_builder). This
means that if there were changes to teh base image we'd need to rebuild
it manually (and not part of CI) which is not good.
After this change I'd completely delete vdk_job_builder which no longer
needed for anything.
Testing Done: this PR (the commit was edited to allow to run on PR , at
the end the CI job will run only in main)
Signed-off-by: Antoni Ivanov [email protected]