vdk-control-cli: Expand missing resource error message #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case when a user creates a job in the control service with a given team name, then changes the team name in the job's config file, the message printed is not clear enough. The message was expanded to inform the user of the aforementioned possible issue. This approach was chosen over checking for this issue specifically, as that approach would have required changes to both vdk-control-cli and the control-service and would have required much longer development time. Closes #605 Testing done: following reproduction steps found in #605 and verified message is printed Signed-off-by: Gabriel Georgiev <[email protected]>
|
That's good. change, as it makes the generic not found message a bit more helpful. but in the ticket #605 I have a more bold goal. I'd like that the control service returns exactly what is not found (not generic 404) but it would say "No job with that name", "no such team exists" . So please keep the ticket open. |
antoniivanov
approved these changes
Feb 15, 2022
gabrielgeorgiev1
deleted the
person/gageorgiev/dont-ask-for-defaulted
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case when a user creates a job in the control service with
a given team name, then changes the team name in the job's config
file, the message printed is not clear enough.
The message was expanded to inform the user of the aforementioned
possible issue. This approach was chosen over checking for this
issue specifically, as that approach would have required changes
to both vdk-control-cli and the control-service and would have
required much longer development time.
Closes #605
Testing done: following reproduction steps found in #605 and
verified message is printed
Signed-off-by: Gabriel Georgiev [email protected]