vdk-ingest-http: additional request parameters support #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plugin was missing connect & read timeout configurations, along with cert file path, and configurable TLS certificate verification that was hardcoded to False (tagged with nosec). Added configurations for INGEST_OVER_HTTP_CONNECT_TIMEOUT_SECONDS, INGEST_OVER_HTTP_READ_TIMEOUT_SECONDS, INGEST_OVER_HTTP_CERT_FILE_PATH, and INGEST_OVER_HTTP_VERIFY that is enabled by default. Testing Done: added test_ingest_over_http_request_parameters_propagation unit test. Signed-off-by: ikoleva <[email protected]>
doks5
approved these changes
Feb 10, 2022
projects/vdk-plugins/vdk-ingest-http/src/vdk/plugin/ingest_http/ingest_http_plugin.py
Show resolved
Hide resolved
projects/vdk-plugins/vdk-ingest-http/src/vdk/plugin/ingest_http/ingest_over_http.py
Show resolved
Hide resolved
Plugin was missing connect & read timeout configurations, along with cert file path, and configurable TLS certificate verification that was hardcoded to False (tagged with nosec). It was also missing retries configuration on total retries count, backoff factor, and status forcelist. Added configurations for INGEST_OVER_HTTP_CONNECT_TIMEOUT_SECONDS, INGEST_OVER_HTTP_READ_TIMEOUT_SECONDS, INGEST_OVER_HTTP_CERT_FILE_PATH, and INGEST_OVER_HTTP_VERIFY that is enabled by default. Added also INGEST_OVER_HTTP_RETRY_TOTAL, INGEST_OVER_HTTP_RETRY_BACKOFF_FACTOR and INGEST_OVER_HTTP_RETRY_STATUS_FORCELIST configurations. Testing Done: added test_ingest_over_http_request_parameters_propagation unit test. Signed-off-by: ikoleva <[email protected]>
doks5
approved these changes
Feb 10, 2022
projects/vdk-plugins/vdk-ingest-http/src/vdk/plugin/ingest_http/ingest_http_plugin.py
Show resolved
Hide resolved
Plugin was missing connect & read timeout configurations, along with cert file path, and configurable TLS certificate verification that was hardcoded to False (tagged with nosec). It was also missing retries configuration on total retries count, backoff factor, and status forcelist. Added configurations for INGEST_OVER_HTTP_CONNECT_TIMEOUT_SECONDS, INGEST_OVER_HTTP_READ_TIMEOUT_SECONDS, INGEST_OVER_HTTP_CERT_FILE_PATH, and INGEST_OVER_HTTP_VERIFY that is enabled by default. Added also INGEST_OVER_HTTP_RETRY_TOTAL, INGEST_OVER_HTTP_RETRY_BACKOFF_FACTOR and INGEST_OVER_HTTP_RETRY_STATUS_FORCELIST configurations. Testing Done: added test_ingest_over_http_request_parameters_propagation unit test. Signed-off-by: ikoleva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vdk-ingest-http: additional request parameters support
Plugin was missing connect & read timeout configurations,
along with cert file path, and configurable TLS certificate
verification that was hardcoded to False (tagged with nosec).
It was also missing retries configuration on total retries count,
backoff factor, and status forcelist.
Added configurations for INGEST_OVER_HTTP_CONNECT_TIMEOUT_SECONDS,
INGEST_OVER_HTTP_READ_TIMEOUT_SECONDS, INGEST_OVER_HTTP_CERT_FILE_PATH,
and INGEST_OVER_HTTP_VERIFY that is enabled by default.
Added also INGEST_OVER_HTTP_RETRY_TOTAL,
INGEST_OVER_HTTP_RETRY_BACKOFF_FACTOR and
INGEST_OVER_HTTP_RETRY_STATUS_FORCELIST configurations.
Testing Done: added test_ingest_over_http_request_parameters_propagation
unit test.
Signed-off-by: ikoleva [email protected]