control-service: fix role permissions for pod/logs #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are requiring permissions for accessing pods/log subresource that seem not to be applicable for pods/log See https://kubernetes.io/docs/reference/access-authn-authz/rbac/#referring-to-resources and it fails on some kubernetes clusters (I assume newer version of kubernets is more strict) Testing Done: helm install relase-foo <edited-helm-chart> and saw it passed Signed-off-by: Antoni Ivanov <[email protected]>
mivanov1988
approved these changes
Feb 10, 2022
ivakoleva
approved these changes
Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are requiring permissions for accessing pods/log subresource that
seem not to be applicable for pods/log See
https://kubernetes.io/docs/reference/access-authn-authz/rbac/#referring-to-resources
and it fails on some kubernetes clusters (I assume newer version of
kubernets is more strict)
Testing Done: helm install relase-foo and saw it
passed
Signed-off-by: Antoni Ivanov [email protected]