control-service: vdk sdk docker repository secret #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently VDK helm chart allows different repositories for data job images and VDK SDK image to be set. However, it doesn't allow different creadentials to be specified. This means that the Data Job Pod can authenticate against only one repository and as a result it can pull only one image. This change provides an ability to specify credentials for VDK SDK repository. Testing Done: unit tests, integration tests and helm template Signed-off-by: Miroslav Ivanov [email protected]
tpalashki
approved these changes
Feb 7, 2022
...ervice/projects/helm_charts/pipelines-control-service/templates/secret_pull_vdk_sdk_img.yaml
Show resolved
Hide resolved
murphp15
reviewed
Nov 16, 2022
| {{- define "imagePullSecretJson" }} | ||
| {{- printf "{\"auths\": {\"%s\": {\"auth\": \"%s\"}}}" .Values.deploymentDockerRepository (printf "%s:%s" .Values.deploymentDockerRegistryUsernameReadOnly .Values.deploymentDockerRegistryPasswordReadOnly | b64enc) | b64enc }} | ||
| {{ include "buildImagePullSecretJson" (list .Values.deploymentDockerRepository .Values.deploymentDockerRegistryUsernameReadOnly .Values.deploymentDockerRegistryPasswordReadOnly) }} |
There was a problem hiding this comment.
@mivanov1988
I am very confused here.
You seem to be passing in different values for the first parameter of the function.
For the first secret(line 224) I see that you are passing in just the registry name.
And for the second(line 227) you are passing in the registry name followed by the repository name.
For me only the first solution works with the jfrog docker repo.
Which repo requires it to have the second format?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, VDK helm chart allows different repositories for data job images
and VDK SDK images to be set. However, it doesn't allow different credentials to be specified.
This means that the Data Job Pod can authenticate against only one repository
and as a result, it can pull only one image.
This change provides an ability to specify credentials for VDK SDK repository.
Testing Done: unit tests, integration tests, and helm template
Signed-off-by: Miroslav Ivanov [email protected]