Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vdk-core] Add ingestion functional tests #691

Merged
merged 3 commits into from
Feb 3, 2022

Conversation

doks5
Copy link
Contributor

@doks5 doks5 commented Feb 1, 2022

As part of #690, the
IngesterRouter and IngesterBase classes were extended to support ingestion
plugin chaining.

Although unit tests were added as part of the aforementioned PR, no functional
tests were implemented.

This change adds functional tests, that verify the new end-to-end ingestion flow
with pre- and post- processors.

Testing Done: functional tests introduced.

Signed-off-by: Andon Andonov [email protected]

@doks5 doks5 self-assigned this Feb 1, 2022
@doks5 doks5 linked an issue Feb 1, 2022 that may be closed by this pull request
@doks5 doks5 force-pushed the person/andonova/ingestion-chaining branch from e13b2b8 to 88a9b3b Compare February 2, 2022 07:35
@doks5 doks5 force-pushed the person/andonova/ingestion-functional-tests branch from c3dae15 to d391d0c Compare February 2, 2022 07:44
@doks5 doks5 force-pushed the person/andonova/ingestion-chaining branch from 88a9b3b to 84366b9 Compare February 2, 2022 22:05
@doks5 doks5 force-pushed the person/andonova/ingestion-functional-tests branch 2 times, most recently from f160519 to 6afb039 Compare February 3, 2022 08:09
@doks5 doks5 force-pushed the person/andonova/ingestion-chaining branch from 84366b9 to d8dc457 Compare February 3, 2022 09:48
@doks5 doks5 force-pushed the person/andonova/ingestion-functional-tests branch 2 times, most recently from f23c158 to 588b888 Compare February 3, 2022 10:14
@doks5 doks5 requested a review from ivakoleva February 3, 2022 10:16
Copy link
Collaborator

@antoniivanov antoniivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I made a very small comment about one test. But ship it after you address it.

@doks5 doks5 force-pushed the person/andonova/ingestion-functional-tests branch from 588b888 to b60f546 Compare February 3, 2022 11:23
@doks5 doks5 force-pushed the person/andonova/ingestion-functional-tests branch 2 times, most recently from a436b35 to 8a3b3d1 Compare February 3, 2022 13:22
@doks5 doks5 force-pushed the person/andonova/ingestion-chaining branch from b3085a2 to 528f54b Compare February 3, 2022 13:38
@ivakoleva ivakoleva deleted the branch main February 3, 2022 13:45
@ivakoleva ivakoleva closed this Feb 3, 2022
@doks5 doks5 reopened this Feb 3, 2022
@doks5 doks5 force-pushed the person/andonova/ingestion-functional-tests branch 2 times, most recently from 913982f to 9c76195 Compare February 3, 2022 14:53
@doks5 doks5 force-pushed the person/andonova/ingestion-functional-tests branch from 9c76195 to 1fa00c8 Compare February 3, 2022 15:01
Base automatically changed from person/andonova/ingestion-chaining to main February 3, 2022 15:09
@doks5 doks5 force-pushed the person/andonova/ingestion-functional-tests branch 2 times, most recently from 04e44be to 0fc5e51 Compare February 3, 2022 15:26
doks5 added 3 commits February 3, 2022 17:35
As part of #682
and #672 the ingestion
interfaces were extended to support ingestion plugin chaining for pre- and
post- processing operations.

This change introduces the implementation of the extended ingestion functionality.
The IngesterRouter and IngesterBase classes are extended to support the use of pre-
and post- ingestion processing plugins.

Testing Done: unit tests; functional tests to follow in a separate PR.

Signed-off-by: Andon Andonov <[email protected]>
Signed-off-by: Andon Andonov <[email protected]>
As part of #690, the
IngesterRouter and IngesterBase classes were extended to support ingestion
plugin chaining.

Although unit tests were added as part of the aforementioned PR, no functional
tests were implemented.

This change adds functional tests, that verify the new end-to-end ingestion flow
with pre- and post- processors.

Testing Done: functional tests introduced.

Signed-off-by: Andon Andonov <[email protected]>
@doks5 doks5 force-pushed the person/andonova/ingestion-functional-tests branch from 0fc5e51 to d32c66f Compare February 3, 2022 15:37
@doks5 doks5 merged commit c5cd250 into main Feb 3, 2022
@doks5 doks5 deleted the person/andonova/ingestion-functional-tests branch February 3, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vdk-core: ingestion payload decoration capability
4 participants