-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vdk-core] Add ingestion functional tests #691
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e13b2b8
to
88a9b3b
Compare
c3dae15
to
d391d0c
Compare
ivakoleva
reviewed
Feb 2, 2022
projects/vdk-core/tests/functional/ingestion/jobs/ingest-method-job/1_ingest_step.py
Outdated
Show resolved
Hide resolved
projects/vdk-core/tests/functional/ingestion/test_ingest_chain.py
Outdated
Show resolved
Hide resolved
88a9b3b
to
84366b9
Compare
f160519
to
6afb039
Compare
84366b9
to
d8dc457
Compare
f23c158
to
588b888
Compare
antoniivanov
reviewed
Feb 3, 2022
antoniivanov
approved these changes
Feb 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I made a very small comment about one test. But ship it after you address it.
588b888
to
b60f546
Compare
ivakoleva
reviewed
Feb 3, 2022
projects/vdk-core/tests/functional/ingestion/test_ingest_chain.py
Outdated
Show resolved
Hide resolved
a436b35
to
8a3b3d1
Compare
b3085a2
to
528f54b
Compare
913982f
to
9c76195
Compare
ivakoleva
approved these changes
Feb 3, 2022
9c76195
to
1fa00c8
Compare
04e44be
to
0fc5e51
Compare
As part of #682 and #672 the ingestion interfaces were extended to support ingestion plugin chaining for pre- and post- processing operations. This change introduces the implementation of the extended ingestion functionality. The IngesterRouter and IngesterBase classes are extended to support the use of pre- and post- ingestion processing plugins. Testing Done: unit tests; functional tests to follow in a separate PR. Signed-off-by: Andon Andonov <[email protected]>
Signed-off-by: Andon Andonov <[email protected]>
As part of #690, the IngesterRouter and IngesterBase classes were extended to support ingestion plugin chaining. Although unit tests were added as part of the aforementioned PR, no functional tests were implemented. This change adds functional tests, that verify the new end-to-end ingestion flow with pre- and post- processors. Testing Done: functional tests introduced. Signed-off-by: Andon Andonov <[email protected]>
0fc5e51
to
d32c66f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #690, the
IngesterRouter and IngesterBase classes were extended to support ingestion
plugin chaining.
Although unit tests were added as part of the aforementioned PR, no functional
tests were implemented.
This change adds functional tests, that verify the new end-to-end ingestion flow
with pre- and post- processors.
Testing Done: functional tests introduced.
Signed-off-by: Andon Andonov [email protected]