vdk-core: adjust defined type for configuration values #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Variable can be added (has its type defined) by one plugin after its value is set by 2nd plugin. In that cases the value would not be cast to the correct type nor validated. This moves that casting/validation at the point of definition (when #add is called) if value is already set for same config key. Testing Done: see unit tests Signed-off-by: Antoni Ivanov <[email protected]>
gabrielgeorgiev1
approved these changes
Jan 28, 2022
antoniivanov
commented
Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Variable can be added (has its type defined) by one plugin after its
value is set by 2nd plugin. In that cases the value would not be cast
to the correct type nor validated. This moves that casting/validation at
the point of definition (when #add is called) if value is already set
for same config key.
Testing Done: see unit tests
Signed-off-by: Antoni Ivanov [email protected]