Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

control-service: add logging when updating last execution #657

Merged
merged 1 commit into from
Jan 4, 2022

Conversation

tpalashki
Copy link
Contributor

We got reports that the last execution status of a data job
can get out-of-sync with the status persisted in the data_job_execution
table. This commit adds logging to the method that updates the last
execution information of a data job so that it is easier to troubleshoot.

Testing done: unit tests

Signed-off-by: Tsvetomir Palashki [email protected]

We got reports that the last execution status of a data job
can get out-of-sync with the status persisted in the data_job_execution
table. This commit adds logging to the method that updates the last
execution information of a data job so that it is easier to troubleshoot.

Testing done: unit tests

Signed-off-by: Tsvetomir Palashki <[email protected]>
@tpalashki tpalashki force-pushed the person/tpalashki/control-service branch from 10c6d71 to ec5ad4e Compare December 23, 2021 08:26
Copy link
Contributor

@doks5 doks5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM.

@tpalashki tpalashki merged commit 91e9d9a into main Jan 4, 2022
@tpalashki tpalashki deleted the person/tpalashki/control-service branch January 4, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants