Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdk-core: Release acceptance test job added to CI/CD #656

Merged

Conversation

YanaZhivkova
Copy link
Contributor

@YanaZhivkova YanaZhivkova commented Dec 22, 2021

We want to avoid releasing broken distributions of vdk-core as much
as possible. The newly added acceptance test would allow us to
release vdk-core only after vdk-heartbeat runs successfully with
a release candidate vdk-core version containing latest changes.

Run vdk-heartbeat on stage pre_release_test of CI/CD with
release candidate distribution and image created during
previous stages - pre_release and pre_release_image.

Testing done: testing CI/CD pipeline on pull request -
https://gitlab.com/vmware-analytics/versatile-data-kit/-/pipelines/434951809
with hard-coded release candidate version of distribution and image (0.0.430145938.dev3240),
which were already created during a previous pipeline - https://gitlab.com/vmware-analytics/versatile-data-kit/-/pipelines/430145938

Signed-off-by: Yana Zhivkova [email protected]

@YanaZhivkova YanaZhivkova force-pushed the person/yzhivkova/vdk-core-release_acceptance_test branch 2 times, most recently from f987307 to 7082bb4 Compare December 22, 2021 13:14
@YanaZhivkova YanaZhivkova linked an issue Dec 22, 2021 that may be closed by this pull request
Copy link
Contributor

@doks5 doks5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We want to avoid releasing broken distributions of vdk-core as much
as possible. The newly added acceptance test would allow us to
release vdk-core only after vdk-heartbeat runs successfully with
a release candidate vdk-core version containing latest changes.

Run vdk-heartbeat on stage pre_release_test of CI/CD with
release candidate distribution and image created during
previous stages - pre_release and pre_release_image.

Testing done: CI/CD pipeline

Signed-off-by: Yana Zhivkova <[email protected]>
@YanaZhivkova YanaZhivkova force-pushed the person/yzhivkova/vdk-core-release_acceptance_test branch from 7082bb4 to aa430b0 Compare December 22, 2021 15:06
@YanaZhivkova YanaZhivkova merged commit 0844d7e into main Dec 22, 2021
@YanaZhivkova YanaZhivkova deleted the person/yzhivkova/vdk-core-release_acceptance_test branch December 22, 2021 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create release-acceptance test step in vdk-core's CI/CD
3 participants