control-service/vdk-cli/vdk-heartbeat: set Pipeline ID as op_id for vdk-heartbeat run #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Truncate job name if longer than 45 symbols (allowed by VDK Control Service) Signed-off-by: Antoni Ivanov <[email protected]>
By setting op_id to be the Pipeline ID we can easier track a given run of vdk-heartebaet as op_id is printed in the logs, it is passed to the job logs, the job name also contains the Op ID . So one can easier see which pipeline generated which job and vice-versa Signed-off-by: Antoni Ivanov <[email protected]>
By setting op_id to be the Pipeline ID we can easier track a given run of vdk-heartebaet as op_id is printed in the logs, it is passed to the job logs, the job name also contains the Op ID . So one can easier see which pipeline generated which job and vice-versa Signed-off-by: Antoni Ivanov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains 3 commits 2 of them set op id to be same as $CI_PIPELINE_ID
By setting op_id to be the Pipeline ID we can easier track a given run of vdk-heartebaet as op_id is printed in the logs, it is passed to the job logs, the job name also contains the Op ID . So one can easier see which pipeline generated which job and vice-versa
And small change in vdk-heartbeat that make sure do not accidentally create job name with too long name (as op id is included in the job name