control-service: ability to add offset to dates in logs URL #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniivanov
approved these changes
Dec 17, 2021
projects/control-service/projects/helm_charts/pipelines-control-service/values.yaml
Outdated
Show resolved
Hide resolved
...ol_service/src/main/java/com/vmware/taurus/service/execution/JobExecutionLogsUrlBuilder.java
Show resolved
Hide resolved
tpalashki
approved these changes
Dec 17, 2021
...control-service/projects/pipelines_control_service/src/main/resources/application.properties
Outdated
Show resolved
Hide resolved
Some of the external systems that our customers use have different time than Control Service. This change aims to introduce configurable offset that will be added to both start_time and end_time varibles during the building of logs URL for each particular execution. Testing Done: unit and integration tests Signed-off-by: Miroslav Ivanov [email protected]
mivanov1988
force-pushed
the
person/miroslavi/add-offset-to-start-time-and-end-time
branch
from
a1a05a1 to
d34494f
Compare
mivanov1988
deleted the
person/miroslavi/add-offset-to-start-time-and-end-time
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the external systems that our customers use
have different time than Control Service.
This change aims to introduce configurable offset
that will be added to both start_time and end_time varibles
during the building of logs URL for each particular execution.
Testing Done: unit and integration tests
Signed-off-by: Miroslav Ivanov [email protected]