control-service: Create Github repository on Helm install #64
Conversation
| helm.sh/hook-delete-policy: before-hook-creation | ||
| helm.sh/resource-policy: keep | ||
| data: | ||
| git-repo-name: {{ .Values.deploymentGitRepoName | default uuidv4 | b64enc | quote }} |
There was a problem hiding this comment.
How this behave during upgrade ?
There was a problem hiding this comment.
It should not trigger during upgrades, there is a pre-upgrade hook for this case.
There was a problem hiding this comment.
What if I install it with defaults and then change the git repo to custom git repository
What if I use custom repository and decide to switch to default. That may be a corner case but we need to be clear what happens.
There was a problem hiding this comment.
Both scenarios work by setting the respective value during upgrade. Let's say you have installed with the defaults and then want to switch to custom git, then you'd do:
helm upgrade name repo/chart --set deploymentGitUrl=gitserver.com/my-custom-repo.git
Works the other way around by setting deploymentGitUrl to "".
|
Reminder: https://github.com/vmware/versatile-data-kit/blob/main/support/git-commit-template.txt Describe the aim of the change and why it is needed. What business problem does it solve? |
| apiVersion: v1 | ||
| kind: Secret | ||
| metadata: | ||
| name: {{ .Release.Name }}-map |
There was a problem hiding this comment.
It's not a map. Please use more descriptive name.
| helm.sh/resource-policy: keep | ||
| data: | ||
| git-repo-name: {{ .Values.deploymentGitRepoName | default uuidv4 | b64enc | quote }} | ||
| git-server: {{ "github.com/versatile-data-kit-jobs" | b64enc | quote }} |
There was a problem hiding this comment.
Why these are hard-coded?
There was a problem hiding this comment.
These are the defaults that we fall back to when no git information is specified during Helm installation. We need to have them somewhere in the chart.
| apiVersion: batch/v1 | ||
| kind: Job | ||
| metadata: | ||
| name: "{{ .Release.Name }}" |
There was a problem hiding this comment.
Use more descriptive name.
tpalashki
force-pushed
the
person/tpalashki/create-git-repo-on-helm-install
branch
from
64b646c to
957eee2
Compare
As part of the effort to improve the experience of users willing to try out the control service, we are making changes to the Helm chart to allow installation with minimal effort. This commit makes Git parameters of the Helm installation optional. If no Git parameters are specified, the Helm installation will automatically create a new public Git repository in https://github.com/versatile-data-kit-jobs. The name of the new repository can be specified via the `deploymentGitRepoName` parameter. If no name is specified, the name will be a randomly generated UUID. Finally, if specified, the `deploymentGitUrl` will take precedence over `deploymentGitRepoName`. Signed-off-by: Tsvetomir Palashki <[email protected]>
tpalashki
force-pushed
the
person/tpalashki/create-git-repo-on-helm-install
branch
from
957eee2 to
9d0fdde
Compare
The Git parameters of the Helm installation are now optional.
If no Git parameters are specified, the Helm installation will
automatically create a new public Git repository in
https://github.com/versatile-data-kit-jobs. The name of the
new repository can be specified via the
deploymentGitRepoNameparameter. If no name is specified, the name will be a randomly
generated UUID.
Finally, if specified, the
deploymentGitUrlwill take precedenceover
deploymentGitRepoName.Signed-off-by: Tsvetomir Palashki [email protected]