Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builds: make pre-requisites explicit #61

Merged
merged 1 commit into from
Aug 10, 2021
Merged

Conversation

antoniivanov
Copy link
Collaborator

First time building of the project locally start from running
./cicd/build.sh . It's good idea to also check for any pre-requisites
required in order to buld all components.

I think that the top level build should not try to build different
projects. Each project should be independant of all other projects (as
if they were in different git repo). This would enfore keeping them
decoupled from each other (no build time dependencies) and facilitate
easer parallel development (people devloping on vdk-core would not
impact those making changes in control-service.

Testing Done: In empty env (using docker):
docker docker run -it -v "$(pwd):/vdk" ubuntu /bin/bash
./cicd/build.sh - prompted to install python and warn me for missing
java
After installing conda - was able to run ./cicd/build.sh succesfully
Then ran vdk-core and vdk-control-cli build succesfully.

control-service build is failing currently and this will be fixed
separately.

First time building of the project locally start from running
./cicd/build.sh . It's good idea to also check for any pre-requisites
required in order to buld all components.

I think that the top level build should not try to build different
projects. Each project should be independant of all other projects (as
if they were in different git repo). This would enfore keeping them
decoupled from each other (no build time dependencies) and facilitate
easer parallel development (people devloping on vdk-core would not
impact those making changes in control-service.

Testing Done: In empty env (using docker):
  docker docker run -it -v "$(pwd):/vdk" ubuntu /bin/bash
./cicd/build.sh - prompted to install python and warn me for missing
java
  After installing conda - was able to run ./cicd/build.sh succesfully
  Then ran vdk-core and vdk-control-cli build succesfully.

control-service build is failing currently and this will be fixed
separately.
Copy link
Contributor

@ivakoleva ivakoleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So root/cicd/build.sh is used to mainly check prerequisites, and print what you need to do next in plaintext;
I am okay with that - I would also be okay if root is able to build everything at once - just to have this enabled if someone wants to rebuild all the components altogether.

About the main build.sh output, again it seems useful for each component contextual ./cicd/build.sh, to be runnable from anywhere - without user changing directories explicitly. It's more convenient, and fail-prone.

I also did build each component successfully, using the build scripts.

@antoniivanov antoniivanov merged commit 8a0df2f into main Aug 10, 2021
@antoniivanov antoniivanov deleted the person/aivanov/build branch August 10, 2021 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants