[vdk-plugins][vdk-server]: Remove authentication imports #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the removal of the reset_default_authentication_disable() and write_default_authentication_disable() logic from vdk-control-cli in 307c1c9 installing vdk-server was not possible due to an ImportError. This change removes the authentication-related imports from vdk-server's installer, and fixes the ImportError raised when running `vdk server --install` Testing Done: Ran `vdk server --install` and observed that vdk-server installs as expected. Signed-off-by: Andon Andonov <[email protected]>
gabrielgeorgiev1
approved these changes
Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the removal of the reset_default_authentication_disable() and
write_default_authentication_disable() logic from vdk-control-cli in
307c1c9
installing vdk-server was not possible due to an ImportError.
This change removes the authentication-related imports from vdk-server's
installer, and fixes the ImportError raised when running
vdk server --installTesting Done: Ran
vdk server --installand observed that vdk-server installs asexpected.
Signed-off-by: Andon Andonov [email protected]