control-service: Expose configuration properties #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniivanov
changed the title
projects/control-service/projects/helm_charts/pipelines-control-service/values.yaml
Outdated
Show resolved
Hide resolved
projects/control-service/projects/helm_charts/pipelines-control-service/values.yaml
Outdated
Show resolved
Hide resolved
|
What is this Executions Cleanup API ? |
mrMoZ1
force-pushed
the
person/mzhivkov/add-config-helm-properties
branch
3 times, most recently
from
21e7a9c to
a0a0d77
Compare
projects/control-service/projects/helm_charts/pipelines-control-service/values.yaml
Outdated
Show resolved
Hide resolved
projects/control-service/projects/helm_charts/pipelines-control-service/values.yaml
Show resolved
Hide resolved
mivanov1988
reviewed
Aug 12, 2021
...control-service/projects/pipelines_control_service/src/main/resources/application.properties
Outdated
Show resolved
Hide resolved
...control-service/projects/pipelines_control_service/src/main/resources/application.properties
Outdated
Show resolved
Hide resolved
...control-service/projects/pipelines_control_service/src/main/resources/application.properties
Outdated
Show resolved
Hide resolved
antoniivanov
approved these changes
Aug 12, 2021
As a part of the new data job execution clean up API we need new properties to expose total time to live, maximum number of executions stored and a shcedule for the new clean up job. Settings exposed as appropriate in the helm charts and/or in the application.properties file Signed-off-by: mzhivkov [email protected]
mrMoZ1
force-pushed
the
person/mzhivkov/add-config-helm-properties
branch
from
00d8b09 to
8936a37
Compare
As a part of the new data job execution clean up API we need new properties to expose total time to live, maximum number of executions stored and a shcedule for the new clean up job. Settings exposed as appropriate in the helm charts and/or in the application.properties file Signed-off-by: mzhivkov [email protected]
mrMoZ1
force-pushed
the
person/mzhivkov/add-config-helm-properties
branch
from
8936a37 to
85e0dae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of the new data job execution clean up API
we need new properties to expose total time to live,
maximum number of executions stored and a shcedule for
the new clean up job. Settings exposed as appropriate in the
helm charts and/or in the application.properties file
Signed-off-by: mzhivkov [email protected]