Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

control-service: add IT for graphQL sort, filter by next run #564

Merged
merged 7 commits into from
Dec 1, 2021

Conversation

mrMoZ1
Copy link
Contributor

@mrMoZ1 mrMoZ1 commented Nov 26, 2021

why: Users requested additional sorting functionality.
We need to add sort on next run in the graphQl API.
The change should be implemented in the back-end.

what: Change is already implemented. Added IT test
that verifies it and informs us of any bugs.

testing: Added new test.

Signed-off-by: Momchil Zhivkov [email protected]

Copy link
Contributor

@doks5 doks5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have only one comment, so, overall, LGTM.

mrMoZ1 added 2 commits November 30, 2021 18:42
Signed-off-by: mrMoZ1 <[email protected]>
Signed-off-by: mrMoZ1 <[email protected]>
@mrMoZ1 mrMoZ1 force-pushed the person/mzhivkov/sort-next-run branch from 24f4934 to 74c6ac7 Compare November 30, 2021 16:44
Signed-off-by: mrMoZ1 <[email protected]>
@mrMoZ1 mrMoZ1 force-pushed the person/mzhivkov/sort-next-run branch from c4437e2 to fbc603c Compare December 1, 2021 08:25
@mrMoZ1 mrMoZ1 force-pushed the person/mzhivkov/sort-next-run branch from 43e44c6 to df52fa6 Compare December 1, 2021 09:54
mrMoZ1 added 2 commits December 1, 2021 13:54
Signed-off-by: mrMoZ1 <[email protected]>
Signed-off-by: mrMoZ1 <[email protected]>
@mrMoZ1 mrMoZ1 merged commit 777f9f0 into main Dec 1, 2021
@mrMoZ1 mrMoZ1 deleted the person/mzhivkov/sort-next-run branch December 1, 2021 13:59
mrMoZ1 pushed a commit that referenced this pull request Dec 6, 2021
why: Users requested additional sorting functionality.
We need to add sort on next run in the graphQl API.
The change should be implemented in the back-end.

what: Change is already implemented. Added IT test
that verifies it and informs us of any bugs.

testing: Added new test.

Signed-off-by: Momchil Zhivkov [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants