cicd/control service: set dockerhub account for default imagePullSecrets #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using dockerhub account we are hitting docker limits less. https://www.docker.com/increase-rate-limit I had set the account for gitlab produced pods/containers but did not for pods/containers produced in other ways (e.g control service). This way it is much less likely to hit docker limit Testing Done: ran the command and saw the secrets appear and to be configured. Immediately after that docker limits errors stopped. Signed-off-by: Antoni Ivanov <[email protected]>
mivanov1988
approved these changes
Nov 23, 2021
ivakoleva
pushed a commit
that referenced
this pull request
Nov 29, 2021
…ets (#550) using dockerhub account we are hitting docker limits less. https://www.docker.com/increase-rate-limit I had set the account for gitlab produced pods/containers but did not for pods/containers produced in other ways (e.g control service). This way it is much less likely to hit docker limit Testing Done: ran the command and saw the secrets appear and to be configured. Immediately after that docker limits errors stopped. Signed-off-by: Antoni Ivanov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using dockerhub account we are hitting docker limits less.
https://www.docker.com/increase-rate-limit
I had set the account for gitlab produced pods/containers but did not
for pods/containers produced in other ways (e.g control service).
This way it is much less likely to hit docker limit
Testing Done: ran the command and saw the secrets appear and to be
configured. Immediately after that docker limits errors stopped.
Signed-off-by: Antoni Ivanov [email protected]