control-service: ability to deploy a data job before all it tests #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mivanov1988
force-pushed
the
person/miroslavi/intengration-tests-extentions
branch
from
31139fc to
6458ddf
Compare
antoniivanov
requested changes
Nov 19, 2021
.../src/integration-test/java/com/vmware/taurus/datajobs/it/common/BaseDataJobDeploymentIT.java
Outdated
Show resolved
Hide resolved
...c/integration-test/java/com/vmware/taurus/datajobs/it/common/DataJobDeploymentExtension.java
Outdated
Show resolved
Hide resolved
.../src/integration-test/java/com/vmware/taurus/datajobs/it/common/BaseDataJobDeploymentIT.java
Show resolved
Hide resolved
...c/integration-test/java/com/vmware/taurus/datajobs/it/common/WebHookServerMockExtension.java
Show resolved
Hide resolved
mivanov1988
force-pushed
the
person/miroslavi/intengration-tests-extentions
branch
3 times, most recently
from
1fb5a79 to
e55849f
Compare
antoniivanov
approved these changes
Nov 19, 2021
...c/integration-test/java/com/vmware/taurus/datajobs/it/common/DataJobDeploymentExtension.java
Outdated
Show resolved
Hide resolved
mivanov1988
force-pushed
the
person/miroslavi/intengration-tests-extentions
branch
2 times, most recently
from
fb846cf to
13e4e9c
Compare
Currently the integration tests that need deployed data job are combined into a one test or they use mocked objects. Since the data job deployment is a time consuming operation and we cannot do it before each test. This change aims to deploy one data job before all tests. Then the tests that need already deployed data job will reuse it. Each test should extend the `BaseDataJobDeploymentIT` class. The `BaseDataJobDeploymentIT` uses Spring Extension (https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/test/context/junit/jupiter/SpringExtension.html) to hook up to the `beforeAll/Each` phase and deploy a data job just once. Testing: ran integration tests locally Signed-off-by: Miroslav Ivanov [email protected]
mivanov1988
force-pushed
the
person/miroslavi/intengration-tests-extentions
branch
from
13e4e9c to
8e59df2
Compare
mivanov1988
deleted the
person/miroslavi/intengration-tests-extentions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the integration tests that need deployed data job are combined
into a one test or they use mocked objects. Since the data job
deployment is a time consuming operation and we cannot do it before each test.
This change aims to deploy one data job before all tests. Then the tests
that need already deployed data job will reuse it.
Each test should extend the
BaseDataJobDeploymentITclass.The
BaseDataJobDeploymentITuses Spring Extension(https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/test/context/junit/jupiter/SpringExtension.html)
to hook up to the
beforeAll/Eachphase and deploy a data job justonce.
Testing: ran integration tests locally
Signed-off-by: Miroslav Ivanov [email protected]