control-service: add team to job deployment #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: #403 API clearly defines that a unique data job asset ID is composite of team and job name. But we are missing that when reporting job deployment This causes any reports relying on correct owner team not to work properly. Testing Done: ran control serviec locally with telemetry webhook set to requestbin and saw telemtetry contains dataJobTeam ``` { "class_name_full" : "com.vmware.taurus.service.deploy.DeploymentProgress", "class_name_short" : "DeploymentProgress", "measurable_args" : "{\"deployment\":{\"dataJobTeam\":\"ai\",\"dataJobName\":\"ai-test\",\"gitCommitSha\":\"e88267478b4cfa83ec1482acf9f902b904eff12e\",\"enabled\":true,\"mode\":\"release\"}}", .... "@table" : "taurus_api_call", } ``` Signed-off-by: Antoni Ivanov <[email protected]>
|
@versatile-data-kit-dev, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction. |
ivakoleva
approved these changes
Nov 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #403
API clearly defines that a unique data job ID is a composite of team
and job name. But we are missing that when reporting job deployment
This causes any reports relying on the correct owner team not to work
properly.
Testing Done: ran control service locally with telemetry webhook set to
https://requestbin.com and saw telemetry contains dataJobTeam
Signed-off-by: Antoni Ivanov [email protected]