[vdk-core]: Post-ingestion specification #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivakoleva
reviewed
Nov 10, 2021
doks5
force-pushed
the
person/andonova/post-ingestion-spec
branch
2 times, most recently
from
e8f2978 to
9ae429f
Compare
ivakoleva
approved these changes
Nov 15, 2021
projects/vdk-core/src/vdk/internal/builtin_plugins/ingestion/ingester_base.py
Show resolved
Hide resolved
antoniivanov
requested changes
Nov 15, 2021
doks5
force-pushed
the
person/andonova/post-ingestion-spec
branch
from
9ae429f to
51ce202
Compare
ivakoleva
reviewed
Nov 16, 2021
projects/vdk-core/tests/vdk/internal/builtin_plugins/ingestion/test_ingester_base.py
Show resolved
Hide resolved
doks5
force-pushed
the
person/andonova/post-ingestion-spec
branch
from
51ce202 to
ab233e3
Compare
antoniivanov
approved these changes
Nov 17, 2021
With the increase in the number of use-cases for ingestion, there arises the need for some users to do post-processing of ingestion data (e.g, to collect ingestion telemetry, etc.). This change aims at introducing a new interface for plugin developers to use when they want to do further processing of payloads after the ingestion operation is complete, or to send telemetry data based on the ingestion operation. Testing Done: Unit test Signed-off-by: Andon Andonov <[email protected]>
doks5
force-pushed
the
person/andonova/post-ingestion-spec
branch
from
ab233e3 to
dd5a362
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the increase in the number of use-cases for ingestion,
there arises the need for some users to do post-processing
of ingestion data (e.g, to collect ingestion telemetry, etc.).
This change aims at introducing a new interface for plugin developers
to use when they want to do further processing of payloads after the
ingestion operation is complete, or to send telemetry data based on the
ingestion operation.
Testing Done: TODO after the spec is finalised.
Signed-off-by: Andon Andonov [email protected]