control-serivice: make smtp server configurable #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YanaZhivkova
approved these changes
Nov 9, 2021
mivanov1988
approved these changes
Nov 9, 2021
The smtp server used for deployment notifications was hard-coded which means it would not have worked . Testing Done: set mail.smtp.host in application-properties and saw it is setting the correct value. Signed-off-by: Antoni Ivanov <[email protected]>
antoniivanov
force-pushed
the
person/aivanov/control-service-smtp
branch
from
ddff3e2 to
5fc9bb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The smtp server used for deployment notifications was hard-coded which
means it would not have worked .
Testing Done: set datajobs.notifications.smtp.host in
application-properties and saw it is setting the correct value.
Signed-off-by: Antoni Ivanov [email protected]